Skip to content

IE11 "Can't redefine non-configurable property 'length'" Error #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2018
Merged

IE11 "Can't redefine non-configurable property 'length'" Error #772

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d76b90
Fix IE11 property override issue
jshcrowthe May 3, 2018
bf74072
[AUTOMATED]: Prettier Code Styling
jshcrowthe May 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/firestore/src/api/database.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1901,9 +1901,17 @@ function throwDocChangesMethodError(): never {
);
}

Object.defineProperty(QuerySnapshot.prototype.docChanges, 'length', {
get: () => throwDocChangesMethodError()
});
/**
* This is technically overwriting the `Function.prototype.length` property of
* `docChanges`. On IE11, the property is improperly defined with
* `{ configurable: false }` which causes this line to throw. Wrap in a
* try-catch to ensure that we still have a functional SDK.
*/
try {
Object.defineProperty(QuerySnapshot.prototype.docChanges, 'length', {
get: () => throwDocChangesMethodError()
});
} catch (err) {} // Ignore this failure intentionally

if (typeof Symbol !== 'undefined') {
Object.defineProperty(QuerySnapshot.prototype.docChanges, Symbol.iterator, {
Expand Down