Skip to content

Skip large sized bloom filter golden tests #7537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Skip large sized bloom filter golden tests #7537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f39d9f3
skip large sized golden tests
milaGGL Aug 8, 2023
0d9b8a9
Update bloom_filter.test.ts
milaGGL Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 28 additions & 15 deletions packages/firestore/test/unit/remote/bloom_filter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,25 +198,38 @@ describe('BloomFilter', () => {
TEST_DATA.count5000Rate0001TestResult
);
});
it('mightContain result for 50000 documents with 1 false positive rate', () => {

// Skip large sized golden tests as they slow down unit test runs without significantly
// improving coverage compared to other golden tests.
// These tests can be run manually if needed.
// eslint-disable-next-line no-restricted-properties
it.skip('mightContain result for 50000 documents with 1 false positive rate', () => {
testBloomFilterAgainstExpectedResult(
TEST_DATA.count50000Rate1TestData,
TEST_DATA.count50000Rate1TestResult
);
});
it('mightContain result for 50000 documents with 0.01 false positive rate', () => {
testBloomFilterAgainstExpectedResult(
TEST_DATA.count50000Rate01TestData,
TEST_DATA.count50000Rate01TestResult
);
//Extend default timeout(2000)
}).timeout(10_000);
it('mightContain result for 50000 documents with 0.0001 false positive rate', () => {
testBloomFilterAgainstExpectedResult(
TEST_DATA.count50000Rate0001TestData,
TEST_DATA.count50000Rate0001TestResult
);
//Extend default timeout(2000)
}).timeout(10_000);
// eslint-disable-next-line no-restricted-properties
it.skip(
'mightContain result for 50000 documents with 0.01 false positive rate',
() => {
testBloomFilterAgainstExpectedResult(
TEST_DATA.count50000Rate01TestData,
TEST_DATA.count50000Rate01TestResult
);
// Extend the default timeout to 10000ms
}
).timeout(10_000);
// eslint-disable-next-line no-restricted-properties
it.skip(
'mightContain result for 50000 documents with 0.0001 false positive rate',
() => {
testBloomFilterAgainstExpectedResult(
TEST_DATA.count50000Rate0001TestData,
TEST_DATA.count50000Rate0001TestResult
);
// Extend the default timeout to 10000ms
}
).timeout(10_000);
});
});