Skip to content

Fix RTDB typings used by compat #7422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Fix RTDB typings used by compat #7422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b065c0d
Trying to fix firestore-types
hsubox76 Jul 6, 2023
ca2a243
Trying to fix firestore-types
hsubox76 Jul 6, 2023
d642e31
Update Firestore and RTDB types
hsubox76 Jul 6, 2023
5120dc8
format
hsubox76 Jul 6, 2023
e021a2c
Add changeset
hsubox76 Jul 6, 2023
67dd5b5
revert firestore changes
hsubox76 Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/soft-grapes-occur.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'firebase': patch
---

Fix typings for v10
6 changes: 5 additions & 1 deletion packages/firebase/compat/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5819,7 +5819,7 @@ declare namespace firebase.database {
* returning true.
*/
forEach(
action: (a: firebase.database.IteratorDataSnapshot) => boolean | void
action: (a: firebase.database.IteratedDataSnapshot) => boolean | void
): boolean;
/**
* Gets the priority value of the data in this `DataSnapshot`.
Expand Down Expand Up @@ -5998,6 +5998,10 @@ declare namespace firebase.database {
toJSON(): Object | null;
}

interface IteratedDataSnapshot extends DataSnapshot {
key: string; // key of the location of this snapshot.
}

/**
* The Firebase Database service interface.
*
Expand Down