Refactoring Messaging #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ping |
mmermerkaya
force-pushed
the
mmermerkaya-refactor
branch
from
8786a49 to
f9d66e3
Compare
mmermerkaya
force-pushed
the
mmermerkaya-refactor
branch
from
f9d66e3 to
68e2827
Compare
Contributor
Author
|
Can someone please review this? |
pinarx
approved these changes
May 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the code by replacing some more promises with async/await and removing deprecated callback API of
Notification.requestPermission().Promise based
requestPermissionAPI is supported by Chrome since version 46 (2015-10-13) and Firefox since version 47 (2016-06-07). Source.