Skip to content

Clarify the usage of const enums and enum maps in auth. #7249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2023
Merged

Clarify the usage of const enums and enum maps in auth. #7249

merged 1 commit into from
Apr 25, 2023

Conversation

@prameshj
Copy link
Contributor

@prameshj prameshj commented Apr 21, 2023

@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f197775

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 21, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (623dba3) and merge commit (34fb1e8).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qRNM0nGOlw.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (623dba3) and merge commit (34fb1e8).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8eXY0V34yp.html

@prameshj prameshj force-pushed the enum-comment branch 2 times, most recently from 024b507 to 2b718aa Compare April 24, 2023 17:31
@prameshj prameshj requested a review from a team as a code owner April 24, 2023 22:11
@prameshj
Clarify the usage of const enums and enum maps in auth.
f197775 
Formatting changes generated with `yarn format`
@prameshj prameshj merged commit a741002 into master Apr 25, 2023
@prameshj prameshj deleted the enum-comment branch April 25, 2023 20:47
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lisajian lisajian Awaiting requested review from lisajian

@sam-gc sam-gc Awaiting requested review from sam-gc

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@hsubox76 hsubox76 Awaiting requested review from hsubox76

1 more reviewer

@renkelvin renkelvin renkelvin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prameshj @google-oss-bot @renkelvin