Port of https://github.com/firebase/firebase-ios-sdk/pull/1114 #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
approved these changes
Apr 25, 2018
| .toNotContain('foo/bar') | ||
| .after(docUpdateRemoteEvent(doc('foo/bar', 1, { it: 'base' }), [1])) | ||
| .afterAllocatingQuery(Query.atPath(path('foo'))) | ||
| .after(docUpdateRemoteEvent(doc('foo/bar', 1, { it: 'base' }), [2])) |
Contributor
There was a problem hiding this comment.
Here and everywhere: Should we use this.lastTargetId instead of hardcoding targetId 2?
Author
There was a problem hiding this comment.
Sadly, we can't. Everything is promise chained, so at the point where the target id is used in defining the step to run, the target allocation hasn't actually happened yet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.