-
Notifications
You must be signed in to change notification settings - Fork 987
Check browser support before instantiating controllers #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ca0e265 to
502ff89
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
I changed the base to |
gauntface
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still against this PR without an API review for the permission change.
|
Permission change? Sure, I can send it to API review. |
502ff89 to
b0aac54
Compare
|
CLAs look good, thanks! |
b0aac54 to
d4d4254
Compare
Prevents issues such as #658 by making sure we don't call any unsupported methods by accident. Also adds some tests for index.ts.
d4d4254 to
e1b2d2b
Compare
|
Went through API review, implemented requested changes. |
Checks browser support before instantiating messaging service controllers and fixes some tests.
I think it's better to let the developer know that Messaging will not work as soon as possible, instead of instantiating a controller without an issue and then throwing an error as soon as they try to use it.
This also prevents issues such as #658 by making sure we don't call any unsupported methods by accident.
This can break users who were not checking browser support before calling
firebase.messaging(), so it should go to the v5 branch.