Skip to content

Reference the signInWithRedirect best practices in docs #6927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2023
Merged

Reference the signInWithRedirect best practices in docs #6927

merged 1 commit into from
Jan 6, 2023

Conversation

@prameshj
Copy link
Contributor

@prameshj prameshj commented Jan 5, 2023

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4bbf432

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@prameshj prameshj marked this pull request as ready for review January 5, 2023 01:26
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 5, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (1455bfa) and merge commit (b709f6e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kElgYf9JbQ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 5, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (1455bfa) and merge commit (b709f6e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/N4wXMGs69y.html

@prameshj
Reference the signInWithRedirect best practices in docs
4bbf432 
Fix a typo in the reauthenticateWithRedirect example.
@prameshj prameshj merged commit cd92522 into master Jan 6, 2023
@prameshj prameshj deleted the prameshj-patch-1 branch January 6, 2023 22:20
@firebase firebase locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sam-gc sam-gc sam-gc approved these changes

@kevinthecheung kevinthecheung kevinthecheung approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@lisajian lisajian Awaiting requested review from lisajian

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prameshj @google-oss-bot @sam-gc @kevinthecheung