Skip to content

Bump firebase-tools version #6902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2022
Merged

Bump firebase-tools version #6902

merged 2 commits into from
Dec 21, 2022

Conversation

@hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Dec 20, 2022

The version we were on may be causing some issues with yarn test:setup.

firebase/firebase-tools#5334 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: f292322

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review December 20, 2022 22:41
dwyfrequency
dwyfrequency approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 20, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (9d2757a) and merge commit (47b91d5).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7hzFB9p293.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 20, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (9d2757a) and merge commit (47b91d5).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Ah5gU5a2O8.html

@hsubox76 hsubox76 merged commit 20e5ef7 into master Dec 21, 2022
@hsubox76 hsubox76 deleted the ch-firebase-tools-bump branch December 21, 2022 21:10
@firebase firebase locked and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@avolkovi avolkovi Awaiting requested review from avolkovi

@sam-gc sam-gc Awaiting requested review from sam-gc

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

1 more reviewer

@dwyfrequency dwyfrequency dwyfrequency approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hsubox76 @google-oss-bot @dwyfrequency