Skip to content

Update proto to include BloomFilter #6780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2022
Merged

Update proto to include BloomFilter #6780

merged 3 commits into from
Nov 15, 2022

Conversation

@milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Nov 10, 2022 •
edited
Loading

Update proto to include bloom filter

  • add expected_count to Target
  • create bloom_filter
  • Add unchanged_names to existence_filter

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 97f0054

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@milaGGL milaGGL self-assigned this Nov 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 10, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (2fdd601) and merge commit (2743e80).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XkJRZs2cYP.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 11, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (2fdd601) and merge commit (2743e80).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FTled9UL8t.html

milaGGL
milaGGL commented Nov 11, 2022
View reviewed changes
@milaGGL milaGGL changed the base branch from master to mila/BloomFilter November 14, 2022 21:54
@milaGGL milaGGL marked this pull request as ready for review November 14, 2022 22:04
@milaGGL milaGGL requested a review from dconeybe November 15, 2022 00:22
dconeybe
dconeybe requested changes Nov 15, 2022
View reviewed changes
@milaGGL milaGGL merged commit 0ccea52 into mila/BloomFilter Nov 15, 2022
@milaGGL milaGGL deleted the mila/BloomFilter-update-proto branch November 15, 2022 01:47
@firebase firebase locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@milaGGL milaGGL

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@milaGGL @google-oss-bot @dconeybe