Updated type of action parameter for DataSnapshot#forEach #6541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maneesht
requested review from
egilmorez,
jsdt,
jmwski,
dwyfrequency and
hsubox76
as code owners
🦋 Changeset detectedLatest commit: c17ed30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Should fix #6368 |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
jmwski
approved these changes
Aug 18, 2022
hsubox76
approved these changes
May 23, 2023
maneesht
added a commit
that referenced
this pull request
Jul 6, 2023
)" This reverts commit 4f904bf.
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores original change that required the
keyparameter in theforEachcallback.As this is a potentially breaking change for extensions, we will wait for a major release for this to be available to users.