Skip to content

Conversation

@tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Aug 8, 2022

Add Firestore named DB support.

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2022

🦋 Changeset detected

Latest commit: 5c8a2fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Minor
@firebase/firestore-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 8, 2022

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (f88805e)Merge (404571a)Diff
    browser264 kB264 kB+194 B (+0.1%)
    esm5327 kB327 kB+178 B (+0.1%)
    main525 kB525 kB+378 B (+0.1%)
    module264 kB264 kB+194 B (+0.1%)
    react-native264 kB264 kB+194 B (+0.1%)
  • @firebase/firestore-lite

    TypeBase (f88805e)Merge (404571a)Diff
    browser80.7 kB80.8 kB+146 B (+0.2%)
    esm596.5 kB96.6 kB+130 B (+0.1%)
    main136 kB136 kB+308 B (+0.2%)
    module80.7 kB80.8 kB+146 B (+0.2%)
    react-native80.9 kB81.0 kB+146 B (+0.2%)
  • bundle

    12 size changes

    TypeBase (f88805e)Merge (404571a)Diff
    firestore (Persistence)274 kB274 kB+113 B (+0.0%)
    firestore (Query Cursors)211 kB211 kB+113 B (+0.1%)
    firestore (Query)212 kB212 kB+113 B (+0.1%)
    firestore (Read data once)200 kB201 kB+113 B (+0.1%)
    firestore (Realtime updates)203 kB203 kB+113 B (+0.1%)
    firestore (Transaction)184 kB184 kB+113 B (+0.1%)
    firestore (Write data)184 kB184 kB+113 B (+0.1%)
    firestore-lite (Query Cursors)68.2 kB68.3 kB+102 B (+0.1%)
    firestore-lite (Query)71.4 kB71.5 kB+102 B (+0.1%)
    firestore-lite (Read data once)55.8 kB55.9 kB+102 B (+0.2%)
    firestore-lite (Transaction)80.3 kB80.4 kB+102 B (+0.1%)
    firestore-lite (Write data)65.5 kB65.6 kB+102 B (+0.2%)

  • firebase

    TypeBase (f88805e)Merge (404571a)Diff
    firebase-compat.js738 kB739 kB+30 B (+0.0%)
    firebase-firestore-compat.js314 kB314 kB+30 B (+0.0%)
    firebase-firestore-lite.js86.1 kB86.2 kB+145 B (+0.2%)
    firebase-firestore.js312 kB313 kB+194 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9HeVDJFSu4.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 8, 2022

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • AbstractUserDataWriter

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size24.1 kB24.1 kB+31 B (+0.1%)
      size-with-ext-deps83.6 kB83.6 kB+30 B (+0.0%)
    • Bytes

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size17.6 kB17.6 kB+31 B (+0.2%)
      size-with-ext-deps77.1 kB77.1 kB+30 B (+0.0%)
    • CACHE_SIZE_UNLIMITED

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.4 kB16.4 kB+31 B (+0.2%)
      size-with-ext-deps75.8 kB75.8 kB+30 B (+0.0%)
    • CollectionReference

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size19.9 kB20.0 kB+31 B (+0.2%)
      size-with-ext-deps79.4 kB79.4 kB+30 B (+0.0%)
    • DocumentReference

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size19.9 kB20.0 kB+31 B (+0.2%)
      size-with-ext-deps79.4 kB79.4 kB+30 B (+0.0%)
    • DocumentSnapshot

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size23.4 kB23.4 kB+31 B (+0.1%)
      size-with-ext-deps82.9 kB82.9 kB+30 B (+0.0%)
    • FieldPath

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size19.0 kB19.1 kB+31 B (+0.2%)
      size-with-ext-deps78.5 kB78.5 kB+30 B (+0.0%)
    • FieldValue

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.4 kB16.4 kB+31 B (+0.2%)
      size-with-ext-deps75.8 kB75.9 kB+30 B (+0.0%)
    • Firestore

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.3 kB16.4 kB+31 B (+0.2%)
      size-with-ext-deps75.8 kB75.8 kB+30 B (+0.0%)
    • FirestoreError

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.3 kB16.4 kB+31 B (+0.2%)
      size-with-ext-deps75.8 kB75.8 kB+30 B (+0.0%)
    • GeoPoint

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.9 kB16.9 kB+31 B (+0.2%)
      size-with-ext-deps76.4 kB76.4 kB+30 B (+0.0%)
    • LoadBundleTask

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size17.2 kB17.2 kB+31 B (+0.2%)
      size-with-ext-deps76.6 kB76.7 kB+30 B (+0.0%)
    • Query

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.5 kB16.5 kB+31 B (+0.2%)
      size-with-ext-deps75.9 kB76.0 kB+30 B (+0.0%)
    • QueryConstraint

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.3 kB16.4 kB+31 B (+0.2%)
      size-with-ext-deps75.8 kB75.8 kB+30 B (+0.0%)
    • QueryDocumentSnapshot

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size23.4 kB23.4 kB+31 B (+0.1%)
      size-with-ext-deps82.9 kB82.9 kB+30 B (+0.0%)
    • QuerySnapshot

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size25.3 kB25.3 kB+31 B (+0.1%)
      size-with-ext-deps84.8 kB84.8 kB+30 B (+0.0%)
    • SnapshotMetadata

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.5 kB16.5 kB+31 B (+0.2%)
      size-with-ext-deps75.9 kB76.0 kB+30 B (+0.0%)
    • Timestamp

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size17.5 kB17.6 kB+31 B (+0.2%)
      size-with-ext-deps77.0 kB77.0 kB+30 B (+0.0%)
    • Transaction

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size49.7 kB49.7 kB+30 B (+0.1%)
      size-with-ext-deps109 kB109 kB+30 B (+0.0%)
    • WriteBatch

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size46.5 kB46.5 kB+30 B (+0.1%)
      size-with-ext-deps106 kB106 kB+30 B (+0.0%)
    • _DatabaseId

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.3 kB16.4 kB+31 B (+0.2%)
      size-with-ext-deps75.8 kB75.8 kB+30 B (+0.0%)
    • _DocumentKey

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size25.6 kB25.6 kB+31 B (+0.1%)
      size-with-ext-deps85.1 kB85.1 kB+30 B (+0.0%)
    • _EmptyAppCheckTokenProvider

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.4 kB16.5 kB+31 B (+0.2%)
      size-with-ext-deps75.9 kB75.9 kB+30 B (+0.0%)
    • _EmptyAuthCredentialsProvider

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.4 kB16.4 kB+31 B (+0.2%)
      size-with-ext-deps75.8 kB75.8 kB+30 B (+0.0%)
    • _FieldPath

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size18.8 kB18.8 kB+31 B (+0.2%)
      size-with-ext-deps78.2 kB78.3 kB+30 B (+0.0%)
    • _cast

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size17.1 kB17.1 kB+31 B (+0.2%)
      size-with-ext-deps76.6 kB76.6 kB+30 B (+0.0%)
    • _debugAssert

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.4 kB16.4 kB+31 B (+0.2%)
      size-with-ext-deps75.8 kB75.8 kB+30 B (+0.0%)
    • _isBase64Available

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.4 kB16.4 kB+31 B (+0.2%)
      size-with-ext-deps75.8 kB75.9 kB+30 B (+0.0%)
    • _logWarn

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.4 kB16.5 kB+31 B (+0.2%)
      size-with-ext-deps75.9 kB75.9 kB+30 B (+0.0%)
    • _validateIsNotUsedTogether

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.3 kB16.4 kB+31 B (+0.2%)
      size-with-ext-deps75.8 kB75.8 kB+30 B (+0.0%)
    • addDoc

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size116 kB116 kB+30 B (+0.0%)
      size-with-ext-deps177 kB177 kB+30 B (+0.0%)
    • arrayRemove

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size28.7 kB28.7 kB+31 B (+0.1%)
      size-with-ext-deps88.3 kB88.3 kB+30 B (+0.0%)
    • arrayUnion

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size28.7 kB28.7 kB+31 B (+0.1%)
      size-with-ext-deps88.3 kB88.3 kB+30 B (+0.0%)
    • clearIndexedDbPersistence

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size25.1 kB25.1 kB+31 B (+0.1%)
      size-with-ext-deps84.7 kB84.8 kB+30 B (+0.0%)
    • collection

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size20.6 kB20.7 kB+31 B (+0.2%)
      size-with-ext-deps80.2 kB80.2 kB+30 B (+0.0%)
    • collectionGroup

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size19.7 kB19.7 kB+31 B (+0.2%)
      size-with-ext-deps79.1 kB79.2 kB+30 B (+0.0%)
    • connectFirestoreEmulator

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size18.1 kB18.2 kB+31 B (+0.2%)
      size-with-ext-deps78.2 kB78.2 kB+30 B (+0.0%)
    • deleteDoc

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size107 kB107 kB+30 B (+0.0%)
      size-with-ext-deps168 kB168 kB+30 B (+0.0%)
    • deleteField

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.7 kB16.8 kB+31 B (+0.2%)
      size-with-ext-deps76.2 kB76.2 kB+30 B (+0.0%)
    • disableNetwork

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size95.7 kB95.8 kB+30 B (+0.0%)
      size-with-ext-deps156 kB156 kB+30 B (+0.0%)
    • doc

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size20.7 kB20.7 kB+31 B (+0.1%)
      size-with-ext-deps80.2 kB80.3 kB+30 B (+0.0%)
    • documentId

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size19.1 kB19.1 kB+31 B (+0.2%)
      size-with-ext-deps78.5 kB78.6 kB+30 B (+0.0%)
    • enableIndexedDbPersistence

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size174 kB174 kB+30 B (+0.0%)
      size-with-ext-deps235 kB235 kB+30 B (+0.0%)
    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size207 kB207 kB+30 B (+0.0%)
      size-with-ext-deps268 kB268 kB+30 B (+0.0%)
    • enableNetwork

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size95.7 kB95.7 kB+30 B (+0.0%)
      size-with-ext-deps156 kB156 kB+30 B (+0.0%)
    • endAt

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size34.7 kB34.7 kB+31 B (+0.1%)
      size-with-ext-deps94.2 kB94.3 kB+30 B (+0.0%)
    • endBefore

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size34.7 kB34.7 kB+31 B (+0.1%)
      size-with-ext-deps94.2 kB94.3 kB+30 B (+0.0%)
    • ensureFirestoreConfigured

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.5 kB16.5 kB+31 B (+0.2%)
      size-with-ext-deps75.9 kB75.9 kB+30 B (+0.0%)
    • executeWrite

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size106 kB106 kB+30 B (+0.0%)
      size-with-ext-deps167 kB167 kB+30 B (+0.0%)
    • getDoc

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size132 kB132 kB+30 B (+0.0%)
      size-with-ext-deps193 kB193 kB+30 B (+0.0%)
    • getDocFromCache

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size88.8 kB88.8 kB+30 B (+0.0%)
      size-with-ext-deps149 kB149 kB+30 B (+0.0%)
    • getDocFromServer

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size132 kB132 kB+30 B (+0.0%)
      size-with-ext-deps193 kB193 kB+30 B (+0.0%)
    • getDocs

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size134 kB134 kB+30 B (+0.0%)
      size-with-ext-deps195 kB195 kB+30 B (+0.0%)
    • getDocsFromCache

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size96.3 kB96.3 kB+30 B (+0.0%)
      size-with-ext-deps156 kB156 kB+30 B (+0.0%)
    • getDocsFromServer

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size134 kB134 kB+30 B (+0.0%)
      size-with-ext-deps195 kB195 kB+30 B (+0.0%)
    • getFirestore

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.4 kB16.5 kB+114 B (+0.7%)
      size-with-ext-deps76.1 kB76.2 kB+113 B (+0.1%)
    • increment

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size17.2 kB17.2 kB+31 B (+0.2%)
      size-with-ext-deps76.6 kB76.7 kB+30 B (+0.0%)
    • initializeFirestore

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size17.0 kB17.1 kB+89 B (+0.5%)
      size-with-ext-deps76.9 kB77.0 kB+88 B (+0.1%)
    • limit

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size17.2 kB17.2 kB+31 B (+0.2%)
      size-with-ext-deps76.7 kB76.7 kB+30 B (+0.0%)
    • limitToLast

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size17.2 kB17.2 kB+31 B (+0.2%)
      size-with-ext-deps76.7 kB76.7 kB+30 B (+0.0%)
    • loadBundle

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size105 kB105 kB+30 B (+0.0%)
      size-with-ext-deps165 kB166 kB+30 B (+0.0%)
    • namedQuery

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size82.2 kB82.3 kB+30 B (+0.0%)
      size-with-ext-deps142 kB142 kB+30 B (+0.0%)
    • onSnapshot

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size135 kB135 kB+30 B (+0.0%)
      size-with-ext-deps195 kB195 kB+30 B (+0.0%)
    • onSnapshotsInSync

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size124 kB124 kB+30 B (+0.0%)
      size-with-ext-deps185 kB185 kB+30 B (+0.0%)
    • orderBy

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size21.5 kB21.5 kB+31 B (+0.1%)
      size-with-ext-deps81.0 kB81.0 kB+30 B (+0.0%)
    • query

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.4 kB16.4 kB+31 B (+0.2%)
      size-with-ext-deps75.8 kB75.9 kB+30 B (+0.0%)
    • queryEqual

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size26.1 kB26.1 kB+31 B (+0.1%)
      size-with-ext-deps85.6 kB85.6 kB+30 B (+0.0%)
    • refEqual

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size20.1 kB20.1 kB+31 B (+0.2%)
      size-with-ext-deps79.6 kB79.7 kB+30 B (+0.0%)
    • runTransaction

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size116 kB116 kB+30 B (+0.0%)
      size-with-ext-deps177 kB177 kB+30 B (+0.0%)
    • serverTimestamp

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.6 kB16.7 kB+31 B (+0.2%)
      size-with-ext-deps76.1 kB76.1 kB+30 B (+0.0%)
    • setDoc

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size115 kB115 kB+30 B (+0.0%)
      size-with-ext-deps176 kB176 kB+30 B (+0.0%)
    • setIndexConfiguration

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size84.9 kB84.9 kB+30 B (+0.0%)
      size-with-ext-deps145 kB145 kB+30 B (+0.0%)
    • setLogLevel

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.4 kB16.4 kB+31 B (+0.2%)
      size-with-ext-deps75.8 kB75.8 kB+30 B (+0.0%)
    • snapshotEqual

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size32.9 kB32.9 kB+31 B (+0.1%)
      size-with-ext-deps92.4 kB92.4 kB+30 B (+0.0%)
    • startAfter

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size34.7 kB34.7 kB+31 B (+0.1%)
      size-with-ext-deps94.2 kB94.3 kB+30 B (+0.0%)
    • startAt

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size34.7 kB34.7 kB+31 B (+0.1%)
      size-with-ext-deps94.2 kB94.3 kB+30 B (+0.0%)
    • terminate

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size16.4 kB16.5 kB+54 B (+0.3%)
      size-with-ext-deps76.1 kB76.1 kB+53 B (+0.1%)
    • updateDoc

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size116 kB116 kB+30 B (+0.0%)
      size-with-ext-deps177 kB177 kB+30 B (+0.0%)
    • waitForPendingWrites

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size96.2 kB96.2 kB+30 B (+0.0%)
      size-with-ext-deps157 kB157 kB+30 B (+0.0%)
    • where

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size41.1 kB41.1 kB+31 B (+0.1%)
      size-with-ext-deps101 kB101 kB+30 B (+0.0%)
    • writeBatch

      Size

      TypeBase (f88805e)Merge (404571a)Diff
      size118 kB118 kB+30 B (+0.0%)
      size-with-ext-deps179 kB179 kB+30 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GmuMKo8c9x.html

@tom-andersen tom-andersen requested a review from wu-hui August 9, 2022 14:41
@tom-andersen tom-andersen marked this pull request as ready for review August 9, 2022 14:41
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR. Mostly nits and requests to add more tests.

@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui Aug 10, 2022
@tom-andersen tom-andersen assigned wu-hui and unassigned tom-andersen Aug 11, 2022
@github-actions github-actions bot added the doc-changes PRs that affect docs label Aug 11, 2022
@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui Aug 15, 2022
@tom-andersen tom-andersen merged commit 0361bf3 into master Aug 22, 2022
@tom-andersen tom-andersen deleted the tomandersen/multiDb branch August 22, 2022 19:18
wu-hui added a commit that referenced this pull request Aug 23, 2022
wu-hui added a commit that referenced this pull request Aug 23, 2022
wu-hui added a commit that referenced this pull request Aug 23, 2022
wu-hui added a commit that referenced this pull request Aug 25, 2022
* Revert "Revert "Tomandersen/multi db (#6518)" (#6552)"

This reverts commit 474025c.

* Make multidb internal for now

* Changeset

* Delete change log
@firebase firebase locked and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

doc-changes PRs that affect docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants