DO NOT MERGE: Firestore COUNT API proposal #6479

dconeybe · 2022-07-27T19:11:45Z

No description provided.

changeset-bot · 2022-07-27T19:11:48Z

⚠️ No Changeset found

Latest commit: 6464b69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2022-07-27T19:36:53Z

Size Report ¹

Affected Products

`@firebase/firestore`

Type	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
browser	264 kB	264 kB	+547 B (+0.2%)
esm5	327 kB	327 kB	+579 B (+0.2%)
main	525 kB	526 kB	+1.41 kB (+0.3%)
module	264 kB	264 kB	+547 B (+0.2%)
react-native	264 kB	264 kB	+547 B (+0.2%)

firebase
Type Base (f5426a5) Merge (bf78ef6) Diff
firebase-firestore.js 851 kB 853 kB +1.35 kB (+0.2%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/LaDzraq59b.html

google-oss-bot · 2022-07-27T19:57:46Z

Size Analysis Report ¹

Affected Products

`@firebase/firestore`

`AggregateQuery`

Size

Type	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
size	?	16.2 kB	? (?)
size-with-ext-deps	?	75.6 kB	? (?)

Dependency

Type	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
functions	?	11 dependencies B F Ka L Nt O U Uu nt su ya	?
classes	?	21 dependencies Ba C J Jc Lu Ma Ml Q Ra W X Y Z ba j oe ru st tt ue z	?
variables	?	D G N ma ns ss x	?
enums	?		?

External Dependency

Module	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
`@firebase/app`	?	SDK_VERSION _registerComponent registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/logger`	?	LogLevel Logger	?
`@firebase/util`	?	FirebaseError	?

`AggregateQuerySnapshot`

Size

Type	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
size	?	16.3 kB	? (?)
size-with-ext-deps	?	75.6 kB	? (?)

Dependency

Type	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
functions	?	11 dependencies B F Ka L Nt O U Uu nt su ya	?
classes	?	21 dependencies Ba C J Jc Lu Ma Ol Q Ra W X Y Z ba j oe ru st tt ue z	?
variables	?	D G N ma ns ss x	?
enums	?		?

External Dependency

Module	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
`@firebase/app`	?	SDK_VERSION _registerComponent registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/logger`	?	LogLevel Logger	?
`@firebase/util`	?	FirebaseError	?

`_setIndexConfiguration`

Dependency

Type Base (f5426a5) Merge (bf78ef6) Diff

functions

113 dependencies

$
$e
$n
An
B
Be
Cn
Dh
Ea
Ee
En
Et
F
Fe
Fl
Fs
Gn
In
Jn
K
Ka
Kn
Ks
Kt
L
Mn
Ms
Nn
Nt
O
Oe
Ol
On
Pe
Pn
Po
Qn
Rt
Sh
Ta
Te
Tn
Tt
U
Un
Us
Ut
Uu
Vn
Wn
Xi
Xn
Yc
Yn
Zc
Zs
_e
_n
_s
ae
ai
an
be
ce
cn
cs
de
dn
ds
ee
ei
en
fn
fs
ge
gn
gs
gt
hn
hs
it
iu
k
ln
ls
me
na
ne
nn
nt
oi
on
pe
ps
pt
qa
qt
re
ri
rt
se
sn
su
te
ui
ve
vn
vo
we
ya
ye
yn
ze

113 dependencies

$
$e
$n
An
B
Be
Cn
Dh
Ea
Ee
En
Et
F
Fe
Fs
Gn
In
Jn
K
Ka
Kl
Kn
Ks
Kt
L
Mn
Ms
Nn
Nt
O
Oe
On
Pe
Pn
Po
Qn
Rt
Sh
Ta
Te
Tn
Tt
U
Un
Us
Ut
Uu
Vn
Wn
Xi
Xn
Yc
Yn
Zc
Zs
_e
_n
_s
ae
ai
an
be
ce
cn
cs
de
dn
ds
ee
ei
en
fn
fs
ge
gn
gs
gt
hn
hs
it
iu
k
ln
ls
me
na
ne
nn
nt
oi
on
pe
ps
pt
qa
ql
qt
re
ri
rt
se
sn
su
te
ui
ve
vn
vo
we
ya
ye
yn
ze

+ Kl
+ ql
- Fl
- Ol

`aggregateQueryEqual`

Size

Type	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
size	?	26.0 kB	? (?)
size-with-ext-deps	?	85.4 kB	? (?)

Dependency

Type	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
functions	?	35 dependencies B Be Bl F K Ka L Nt O Oe U Ut Uu _e ae an de dn ee en fn hn it ka ne nt re rt se sn su te ve wn ya	?
classes	?	28 dependencies Ba C J Jc Lu Ma Me Q Ra Va W X Xt Y Z Ze at ba ft j oe ru st tn tt ue ut z	?
variables	?	D G N Zt lt ma ns ss x	?
enums	?		?

External Dependency

Module	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
`@firebase/app`	?	SDK_VERSION _registerComponent registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/logger`	?	LogLevel Logger	?
`@firebase/util`	?	FirebaseError getModularInstance	?

`aggregateQuerySnapshotEqual`

Size

Type	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
size	?	26.1 kB	? (?)
size-with-ext-deps	?	85.5 kB	? (?)

Dependency

Type	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
functions	?	36 dependencies B Be Bl F K Ka L Ll Nt O Oe U Ut Uu _e ae an de dn ee en fn hn it ka ne nt re rt se sn su te ve wn ya	?
classes	?	28 dependencies Ba C J Jc Lu Ma Me Q Ra Va W X Xt Y Z Ze at ba ft j oe ru st tn tt ue ut z	?
variables	?	D G N Zt lt ma ns ss x	?
enums	?		?

External Dependency

Module	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
`@firebase/app`	?	SDK_VERSION _registerComponent registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/logger`	?	LogLevel Logger	?
`@firebase/util`	?	FirebaseError getModularInstance	?

`countQuery`

Size

Type	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
size	?	16.3 kB	? (?)
size-with-ext-deps	?	75.6 kB	? (?)

Dependency

Type	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
functions	?	12 dependencies B F Fl Ka L Nt O U Uu nt su ya	?
classes	?	21 dependencies Ba C J Jc Lu Ma Ml Q Ra W X Y Z ba j oe ru st tt ue z	?
variables	?	D G N ma ns ss x	?
enums	?		?

External Dependency

Module	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
`@firebase/app`	?	SDK_VERSION _registerComponent registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/logger`	?	LogLevel Logger	?
`@firebase/util`	?	FirebaseError	?

`getAggregateFromServerDirect`

Size

Type	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
size	?	16.4 kB	? (?)
size-with-ext-deps	?	75.7 kB	? (?)

Dependency

Type	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
functions	?	12 dependencies $l B F Ka L Nt O U Uu nt su ya	?
classes	?	21 dependencies Ba C J Jc Lu Ma Ol Q Ra W X Y Z ba j oe ru st tt ue z	?
variables	?	D G N ma ns ss x	?
enums	?		?

External Dependency

Module	Base (`f5426a5`)	Merge (`bf78ef6`)	Diff
`@firebase/app`	?	SDK_VERSION _registerComponent registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/logger`	?	LogLevel Logger	?
`@firebase/util`	?	FirebaseError	?

`writeBatch`

Dependency

Type Base (f5426a5) Merge (bf78ef6) Diff

functions

176 dependencies

$
$e
$n
$s
Ah
An
B
Bc
Be
Bu
Ch
Cn
Cu
Dh
Du
Ea
Ee
En
Et
F
Fe
Fs
Fu
Gn
Gs
Ic
Ih
In
Iu
Jn
Js
K
Ka
Kn
Ks
Kt
L
Ml
Mn
Ms
Mu
Ne
Nn
Ns
Nt
Nu
O
Oe
On
Os
Ou
Pc
Pe
Ph
Pl
Pn
Po
Pu
Qn
Rh
Rn
Rt
Sh
So
Su
Ta
Te
Th
Tn
Tt
U
Un
Us
Ut
Uu
Vn
Vo
Vu
Wn
Xc
Xi
Xn
Yc
Yn
Yu
Zc
Zs
_c
_e
_n
_s
ae
ah
ai
al
an
be
bh
bu
ce
ci
cn
cs
de
dh
dn
ds
du
ee
ei
en
fc
fh
fl
fn
fs
fu
gc
ge
gn
gs
he
hn
hs
ia
is
it
iu
jn
k
ks
ku
ln
ls
mc
me
mn
ne
nn
nt
oi
on
pc
pe
ps
qa
qs
qt
re
ri
rs
rt
se
sn
su
ta
te
ui
un
vc
ve
vh
vn
vo
vt
vu
we
wn
xo
xs
xu
ya
ye
yn
ze
zs

176 dependencies

$
$e
$n
$s
Ah
An
B
Bc
Be
Bu
Ch
Cn
Cu
Dh
Du
Ea
Ee
En
Et
F
Fe
Fs
Fu
Gn
Gs
Ic
Ih
In
Iu
Jn
Js
K
Ka
Kn
Ks
Kt
L
Mn
Ms
Mu
Ne
Nn
Ns
Nt
Nu
O
Oe
On
Os
Ou
Pc
Pe
Ph
Pl
Pn
Po
Pu
Qn
Rh
Rn
Rt
Sh
So
Su
Ta
Te
Th
Tn
Tt
U
Ul
Un
Us
Ut
Uu
Vn
Vo
Vu
Wn
Xc
Xi
Xn
Yc
Yn
Yu
Zc
Zs
_c
_e
_n
_s
ae
ah
ai
al
an
be
bh
bu
ce
ci
cn
cs
de
dh
dn
ds
du
ee
ei
en
fc
fh
fl
fn
fs
fu
gc
ge
gn
gs
he
hn
hs
ia
is
it
iu
jn
k
ks
ku
ln
ls
mc
me
mn
ne
nn
nt
oi
on
pc
pe
ps
qa
qs
qt
re
ri
rs
rt
se
sn
su
ta
te
ui
un
vc
ve
vh
vn
vo
vt
vu
we
wn
xo
xs
xu
ya
ye
yn
ze
zs

+ Ul
- Ml

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/j1bOcsXhn9.html

milaGGL · 2022-07-29T23:11:11Z

packages/firestore/src/lite-api/aggregate.ts

+export class AggregateQuery {
+
+  /** @hideconstructor */
+  constructor(query: Query<unknown>) {


why this is Query<unknown> instead of Query<T> or Query? 🤔

COUNT API added

21a8c91

dconeybe added the api: firestore label Jul 27, 2022

dconeybe self-assigned this Jul 27, 2022

Update API reports

6464b69

github-actions bot added the doc-changes PRs that affect docs label Jul 27, 2022

milaGGL reviewed Jul 29, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DO NOT MERGE: Firestore COUNT API proposal #6479

DO NOT MERGE: Firestore COUNT API proposal #6479

Uh oh!

dconeybe commented Jul 27, 2022

Uh oh!

changeset-bot bot commented Jul 27, 2022 •

edited

Loading

Uh oh!

google-oss-bot commented Jul 27, 2022

`@firebase/firestore`

`firebase`

Uh oh!

google-oss-bot commented Jul 27, 2022

`@firebase/firestore`

`AggregateQuery`

`AggregateQuerySnapshot`

`_setIndexConfiguration`

`aggregateQueryEqual`

`aggregateQuerySnapshotEqual`

`countQuery`

`getAggregateFromServerDirect`

`writeBatch`

Uh oh!

milaGGL Jul 29, 2022 •

edited

Loading

Uh oh!

Uh oh!

DO NOT MERGE: Firestore COUNT API proposal #6479

Are you sure you want to change the base?

DO NOT MERGE: Firestore COUNT API proposal #6479

Uh oh!

Conversation

dconeybe commented Jul 27, 2022

Uh oh!

changeset-bot bot commented Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Jul 27, 2022

Size Report 1

Affected Products

@firebase/firestore

firebase

Test Logs

Uh oh!

google-oss-bot commented Jul 27, 2022

Size Analysis Report 1

Affected Products

@firebase/firestore

AggregateQuery

AggregateQuerySnapshot

_setIndexConfiguration

aggregateQueryEqual

aggregateQuerySnapshotEqual

countQuery

getAggregateFromServerDirect

writeBatch

Test Logs

Uh oh!

milaGGL Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

changeset-bot bot commented Jul 27, 2022 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`firebase`

Size Analysis Report ¹

`@firebase/firestore`

`AggregateQuery`

`AggregateQuerySnapshot`

`_setIndexConfiguration`

`aggregateQueryEqual`

`aggregateQuerySnapshotEqual`

`countQuery`

`getAggregateFromServerDirect`

`writeBatch`

milaGGL Jul 29, 2022 •

edited

Loading