Skip to content

Conversation

@schmidt-sebastian
Copy link
Contributor

Fixes #5983

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2022

⚠️ No Changeset found

Latest commit: 78d6e92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 11, 2022

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 11, 2022

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a 0.5KB increase isn't a big deal since it fixes a pretty important use case.

@schmidt-sebastian
Copy link
Contributor Author

The increase is also only for Node.

@schmidt-sebastian schmidt-sebastian merged commit 307d019 into master Feb 16, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/grpcimports branch February 16, 2022 17:38
@firebase firebase locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'The requested module '@grpc/grpc-js' is expected to be of type CommonJS' Getting issue while deploying next js application by gcp CICD pipeline.

3 participants