Skip to content

Remove private types in app-compat #5385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2021
Merged

Remove private types in app-compat #5385

merged 2 commits into from
Aug 30, 2021

Conversation

@Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Aug 26, 2021

fixes #5382

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 7a2ca8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/app-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2021 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 26, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (c8701ec) and head commit (c1643eb).

@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label Aug 26, 2021
@Feiyang1 Feiyang1 removed the doc-changes PRs that affect docs label Aug 26, 2021
@Feiyang1 Feiyang1 requested a review from egilmorez as a code owner August 27, 2021 17:29
@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label Aug 27, 2021
@Feiyang1 Feiyang1 merged commit 1b33fda into master Aug 30, 2021
@Feiyang1 Feiyang1 deleted the fei-compat-types branch August 30, 2021 17:40
@google-oss-bot google-oss-bot mentioned this pull request Aug 30, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@egilmorez egilmorez

@hsubox76 hsubox76

Labels

doc-changes PRs that affect docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Module '"@firebase/app"' has no exported member '_FirebaseAppInternal'.

4 participants

@Feiyang1 @google-oss-bot @hsubox76 @egilmorez