Skip to content

update READMEs with v9 info #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2021
Merged

update READMEs with v9 info #5383

merged 2 commits into from
Aug 26, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 99b618b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

egilmorez
egilmorez approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just a couple nits, thanks!

hsubox76
hsubox76 approved these changes Aug 26, 2021
View reviewed changes
@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 26, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (d0d3acb) and head commit (4e2299a).

@Feiyang1 Feiyang1 merged commit 8b8ec0d into master Aug 26, 2021
@Feiyang1 Feiyang1 deleted the fei-readme branch August 26, 2021 20:38
@Feiyang1 Feiyang1 mentioned this pull request Aug 30, 2021
Closed
@firebase firebase locked and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@egilmorez egilmorez egilmorez approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@egilmorez egilmorez

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Feiyang1 @google-oss-bot @egilmorez @hsubox76