Skip to content

[Auth] Fix typo in invalid SMS code error message #4962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2021
Merged

[Auth] Fix typo in invalid SMS code error message #4962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1701c7
Fix typo in invalid SMS code error message
sam-gc Jun 1, 2021
575d01d
Formatting
sam-gc Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages-exp/auth-exp/src/api/authentication/mfa.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ describe('api/authentication/finalizeSignInPhoneMfa', () => {

await expect(finalizeSignInPhoneMfa(auth, request)).to.be.rejectedWith(
FirebaseError,
'Firebase: The SMS verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure use the verification code provided by the user. (auth/invalid-verification-code).'
'Firebase: The SMS verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure to use the verification code provided by the user. (auth/invalid-verification-code).'
);
expect(mock.calls[0].request).to.eql({
tenantId: null,
Expand Down
4 changes: 2 additions & 2 deletions packages-exp/auth-exp/src/api/authentication/sms.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ describe('api/authentication/signInWithPhoneNumber', () => {

await expect(signInWithPhoneNumber(auth, request)).to.be.rejectedWith(
FirebaseError,
'Firebase: The SMS verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure use the verification code provided by the user. (auth/invalid-verification-code).'
'Firebase: The SMS verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure to use the verification code provided by the user. (auth/invalid-verification-code).'
);
expect(mock.calls[0].request).to.eql(request);
});
Expand Down Expand Up @@ -222,7 +222,7 @@ describe('api/authentication/linkWithPhoneNumber', () => {

await expect(linkWithPhoneNumber(auth, request)).to.be.rejectedWith(
FirebaseError,
'Firebase: The SMS verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure use the verification code provided by the user. (auth/invalid-verification-code).'
'Firebase: The SMS verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure to use the verification code provided by the user. (auth/invalid-verification-code).'
);
expect(mock.calls[0].request).to.eql(request);
});
Expand Down
2 changes: 1 addition & 1 deletion packages-exp/auth-exp/src/core/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ function _debugErrorMap(): ErrorMap<AuthErrorCode> {
[AuthErrorCode.INVALID_AUTH_EVENT]: 'An internal AuthError has occurred.',
[AuthErrorCode.INVALID_CODE]:
'The SMS verification code used to create the phone auth credential is ' +
'invalid. Please resend the verification code sms and be sure use the ' +
'invalid. Please resend the verification code sms and be sure to use the ' +
'verification code provided by the user.',
[AuthErrorCode.INVALID_CONTINUE_URI]:
'The continue URL provided in the request is invalid.',
Expand Down
4 changes: 2 additions & 2 deletions packages/auth/src/error_auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* @license
* Copyright 2017 Google Inc.
* Copyright 2017 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -280,7 +280,7 @@ fireauth.AuthError.MESSAGES_[fireauth.authenum.Error.INVALID_AUTH_EVENT] =
'An internal error has occurred.';
fireauth.AuthError.MESSAGES_[fireauth.authenum.Error.INVALID_CODE] =
'The SMS verification code used to create the phone auth credential is ' +
'invalid. Please resend the verification code sms and be sure use the ' +
'invalid. Please resend the verification code sms and be sure to use the ' +
'verification code provided by the user.';
fireauth.AuthError.MESSAGES_[fireauth.authenum.Error.INVALID_CONTINUE_URI] =
'The continue URL provided in the request is invalid.';
Expand Down