fix broken typings for the non modular RTDB package #4858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
requested review from
hiranya911,
hsubox76,
jsdt and
schmidt-sebastian
as code owners
|
Member
Author
|
@hiranya911 FYI |
hsubox76
reviewed
May 1, 2021
Contributor
hsubox76
left a comment
hsubox76
left a comment
There was a problem hiding this comment.
Seems like some lint comments are needed on the any lines.
Contributor
Binary Size ReportAffected SDKs
Test Logs |
schmidt-sebastian
approved these changes
May 3, 2021
Contributor
schmidt-sebastian
left a comment
schmidt-sebastian
left a comment
There was a problem hiding this comment.
Sad panda (for now). Also ship it!
Comment on lines
+53
to
+81
| export async function addBlankLines(outputLocation: string): Promise<void> { | ||
| const eslint = new ESLint({ | ||
| fix: true, | ||
| overrideConfig: { | ||
| parserOptions: { | ||
| ecmaVersion: 2017, | ||
| sourceType: 'module', | ||
| tsconfigRootDir: __dirname, | ||
| project: ['./tsconfig.eslint.json'] | ||
| }, | ||
| env: { | ||
| es6: true | ||
| }, | ||
| plugins: ['@typescript-eslint'], | ||
| parser: '@typescript-eslint/parser', | ||
| rules: { | ||
| 'unused-imports/no-unused-imports-ts': ['off'], | ||
| // add blank lines after imports. Otherwise removeUnusedImports() will remove the comment | ||
| // of the first item after the import block | ||
| 'padding-line-between-statements': [ | ||
| 'error', | ||
| { 'blankLine': 'always', 'prev': 'import', 'next': '*' } | ||
| ] | ||
| } | ||
| } | ||
| }); | ||
| const results = await eslint.lintFiles(outputLocation); | ||
| await ESLint.outputFixes(results); | ||
| } |
Contributor
There was a problem hiding this comment.
YAY. I was not able to figure this out.
hsubox76
approved these changes
May 3, 2021
yuchenshi
pushed a commit
that referenced
this pull request
May 3, 2021
* fix broken typings for the non modular sdk * fix lint errors * preserve comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin SDK couldn't upgrade to the latest version because our typings are broken. They reference typings from
@firebase/app-exp. This ugly workaround fixes it.These changes are internal, so no public types are affected.