Skip to content

Conversation

@sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Feb 25, 2021

This change adds Cordova support to the compat package by dynamically choosing which resolver to use at runtime. In order to get this to work, I had to change the Cordova plugin types to be declared as an interface extending Window instead of passive declare namespace. Honestly this is probably for the better because that's broken like half the time

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 25, 2021

Binary Size Report

Affected SDKs

No changes between base commit (d4ba8da) and head commit (e2c5fe1).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 25, 2021

Size Analysis Report

Affected Products

No changes between base commit (d4ba8da) and head commit (e2c5fe1).

@sam-gc sam-gc merged commit 3862071 into master Feb 25, 2021
@sam-gc sam-gc deleted the samgho/compat-popup-redirect branch February 25, 2021 21:42
@firebase firebase locked and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants