Skip to content

Remove functions-types-exp and clean up stray app-types-exp #4511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2021
Merged

Remove functions-types-exp and clean up stray app-types-exp #4511

merged 3 commits into from
Feb 23, 2021

Conversation

@hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Feb 23, 2021

  • Remove functions-types-exp
  • Clean up stray references to app-types-exp
  • Remove storage-types-exp.api.md
  • yarn.lock is always changing because firebase-admin and database

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 23, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (6a86a1b) and head commit (824a0cd).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 23, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (6a86a1b) and head commit (824a0cd).

@hsubox76 hsubox76 merged commit 1003b8d into master Feb 23, 2021
@hsubox76 hsubox76 deleted the ch-rm-functions-types branch February 23, 2021 19:35
@firebase firebase locked and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hiranya911 hiranya911 Awaiting requested review from hiranya911

1 more reviewer

@Feiyang1 Feiyang1 Feiyang1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hsubox76 @google-oss-bot @Feiyang1