Skip to content

Add an app activity listener to more-or-less complete the redirect sign in flow. #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 16, 2021
Merged

Add an app activity listener to more-or-less complete the redirect sign in flow. #4472

merged 7 commits into from
Feb 16, 2021

Conversation

@sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Feb 12, 2021

This change also reshuffles the Cordova code structure a bit

@sam-gc sam-gc requested review from avolkovi and yuchenshi February 12, 2021 23:33
@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 52bef71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sam-gc
sam-gc commented Feb 12, 2021
View reviewed changes
packages-exp/auth-exp/src/platform_cordova/popup_redirect/events.ts

/** Custom AuthEventManager that adds passive listeners to events */
export class CordovaAuthEventManager extends AuthEventManager {
private readonly passiveListeners = new Set<(e: AuthEvent) => void>();
Copy link
Contributor Author

@sam-gc sam-gc Feb 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly moved from popup_redirect.ts except for the new initPromise field and the initialized() function

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 12, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (9ac2093) and head commit (6eef2f5).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 12, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (9ac2093) and head commit (6eef2f5).

yuchenshi
yuchenshi approved these changes Feb 16, 2021
View reviewed changes
@sam-gc sam-gc merged commit 40afc0c into master Feb 16, 2021
@sam-gc sam-gc deleted the samgho/cdv-more-events branch February 16, 2021 21:42
@firebase firebase locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@yuchenshi yuchenshi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sam-gc @google-oss-bot @yuchenshi