Skip to content

Tree-Shake OperationSource #4470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 16, 2021
Merged

Tree-Shake OperationSource #4470

merged 5 commits into from
Feb 16, 2021

Conversation

@schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Feb 12, 2021

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 09998da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 12, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (47e035f) Head (38c9911) Diff
    browser 277 kB 277 kB -220 B (-0.1%)
    esm2017 245 kB 245 kB -135 B (-0.1%)
    main 280 kB 280 kB -225 B (-0.1%)
    module 277 kB 277 kB -220 B (-0.1%)

  • @firebase/database-exp

    Type Base (47e035f) Head (38c9911) Diff
    browser 278 kB 278 kB -220 B (-0.1%)
    esm2017 243 kB 243 kB -135 B (-0.1%)
    main 280 kB 280 kB -225 B (-0.1%)
    module 278 kB 278 kB -220 B (-0.1%)

  • firebase

    Type Base (47e035f) Head (38c9911) Diff
    firebase-database.js 193 kB 193 kB -194 B (-0.1%)
    firebase.js 854 kB 854 kB -195 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 12, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (47e035f) and head commit (37d172e).

Feiyang1
Feiyang1 previously requested changes Feb 12, 2021
View reviewed changes
Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can start turning on eslint rules that we turned off for database as part of the rewrite?

@schmidt-sebastian
Copy link
Contributor Author

schmidt-sebastian commented Feb 12, 2021

Perhaps we can start turning on eslint rules that we turned off for database as part of the rewrite?

Is it possible to do this only for modified files?

hsubox76
hsubox76 reviewed Feb 16, 2021
View reviewed changes
@schmidt-sebastian schmidt-sebastian merged commit 8c92c1a into master Feb 16, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/operationsource branch February 16, 2021 19:54
@firebase firebase locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@jsdt jsdt Awaiting requested review from jsdt

+1 more reviewer

@Feiyang1 Feiyang1 Feiyang1 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Feiyang1 Feiyang1

@hsubox76 hsubox76

Labels

api: database

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@schmidt-sebastian @google-oss-bot @Feiyang1 @hsubox76