Skip to content

Remove no-android from Bundle tests #4313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Remove no-android from Bundle tests #4313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/firestore/test/unit/generate_spec_json.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ set -o errexit

DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
NPM_BIN_DIR="$(npm bin)"
TSNODE="$NPM_BIN_DIR/ts-node"
TSNODE="$NPM_BIN_DIR/ts-node "
GENERATE_SPEC_JS="$DIR/generate_spec_json.js"

export TS_NODE_CACHE=NO
export TS_NODE_COMPILER_OPTIONS='{"module":"commonjs"}'
export TS_NODE_PROJECT="$DIR/../../tsconfig.json"

$TSNODE $GENERATE_SPEC_JS "$@"
$TSNODE --require ../../index.node.ts $GENERATE_SPEC_JS "$@"
2 changes: 1 addition & 1 deletion packages/firestore/test/unit/specs/bundle_spec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function bundleWithDocumentAndQuery(
);
}

describeSpec('Bundles:', ['no-ios', 'no-android'], () => {
describeSpec('Bundles:', ['no-ios'], () => {
specTest('Newer docs from bundles should overwrite cache', [], () => {
const query1 = query('collection');
const docA = doc('collection/a', 1000, { value: 'a' });
Expand Down