Expose emulator config for the Auth SDK #4280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-gc
requested review from
Feiyang1,
hiranya911,
hsubox76 and
yuchenshi
as code owners
🦋 Changeset detectedLatest commit: b827513 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
avolkovi
approved these changes
Jan 12, 2021
yuchenshi
approved these changes
Jan 12, 2021
Member
yuchenshi
left a comment
yuchenshi
left a comment
There was a problem hiding this comment.
Rubber stamping since this is already reviewed internally
…ase/firebase-js-sdk into samgho/auth-emulator-config-getter
Feiyang1
approved these changes
Jan 13, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add the relevant bits to the externs in the firebase package, so that other Closure libraries can consume the new features.