Firestore GeoPoint query ignores longitude

[lmgc-code]

• Firebase SDK version: 5.0.1
• Firebase Product: firestore

Firestore query on GeoPoint fields, compares the latitude but ignores longitude. Result contains all the documents with correct latitude, but all available longitude, ignoring the query input.

In the case of getting all the documents within map's bounding box, it returns with all the points vertically within the view, but horizontally, across the entire globe.

Following example should return only one location (40, -80), but it returns two including (50,-90) .

Relevant Code:

    const path='locations';

    const southWest=new firebase.firestore.GeoPoint( 35, -85);
    const northEast=new firebase.firestore.GeoPoint( 60, -75);

    Promise.all( [
      firebase.firestore().collection(path).doc().set( {location: new firebase.firestore.GeoPoint( 30, -70 )}),
      firebase.firestore().collection(path).doc().set( {location: new firebase.firestore.GeoPoint( 40, -80 )}),
      firebase.firestore().collection(path).doc().set( {location: new firebase.firestore.GeoPoint( 50, -90 )})
    ])
    .then(()=>{
      return firebase.firestore().collection(path)
       .where(`location`, '>' , southWest )
       .where(`location`, '<' , northEast )
       .get()
    })
   .then(snapshot=>{
     snapshot.docs.forEach(doc=>{
       console.log(JSON.stringify(doc.data()))
     })
   })

[rsgowman]

Unfortunately, this is currently working as intended. The comparison algorithm for GeoPoints compares the latitude first, and only in cases where the latitude is the same, does it examine the longitude.

The function in question is here:

https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore/src/api/geo_point.ts#L77

Unfortunately, we don't support geoqueries yet, so it's not really possible to do this in a useful manner. Here's some useful stackoverflow discussions on the topic:

https://stackoverflow.com/questions/46607760/how-to-query-closest-geopoints-in-a-collection-in-firebase-cloud-firestore/
https://stackoverflow.com/questions/46553682/is-there-a-way-to-use-geofire-with-firestore

A possible workaround might be to run a where query for just the latitude, and then manually query the result set for longitude.

[lmgc-code]

Thank you for reply. I believe the issue is the "or" operation (||) in GeoPoint._compareTo, it should instead be "and" operation (&&) in firebase-js-sdk/blob/master/packages/firestore/src/api/geo_point.ts#L77:

  _compareTo(other: GeoPoint): number {
    return (
      primitiveComparator(this._lat, other._lat) &&
      primitiveComparator(this._long, other._long)
    );
  }

[wilhuff]

The current implementation is correct. The semantics of GeoPoint comparison in Firestore are:

• Compare latitude
• If latitudes are equal, compare longitudes

The comparison is done this way because for the backend just treats GeoPoints as a pair. The SDKs have to match the server behavior.

We recognize that this isn't a useful definition of queries, and except for concerns about data interoperability with Cloud Datastore, we wouldn't have published the GeoPoint type yet because of this. We intend to implement proper geo query support, though this will likely come after Firestore hits GA.

[merlinnot]

Just FYI, you can easily emulate geo-queries in Firestore using some space-filling curves.

[lmgc-code]

@wilhuff , I'm afraid it doesn't work like the semantics you mentioned. In the example provided, the latitude is within the range and compare returns true, however according to your semantic, it should compare longitude next, but it doesn't.

[lmgc-code]

@wilhuff, Appologies, I missed the "equal" in your semantic. so for comparison such as ">" or "<", are you implying the latitude should be equal?

[wilhuff]

primitiveComparator does three-way comparison, not equality checks.

Bounding box queries just aren't going to work. The results you're getting are expected. (50, -90) has a latitude within the range of 35 to 60. Longitude isn't even considered in this case.

Longitude would only be considered if you had a point whose latitude was equal to one of the boundaries of the range you're considering.

[MvRemmerden]

@wilhuff Is there any timeline on when proper geo query support will come?

[wilhuff]

Sorry, we have nothing to announce at this time.

I don't have a good written summary of this, but we did announce a few things at Cloud Next '18--these things are just around the corner. Nearly all of our effort lately has been focused on transitioning from a limited beta to something much more broadly useful. I realize this is no consolation for this specific feature, but at least you can see we've been busy :-).

[ollyde]

Any news on this?

For anyone else while we wait, GeoFirestore is really good, can handle millions of objects I've seen so far pretty well. But make a separate collection (for example 'GeoCacheUsers' or whatever and query that.)

[wilhuff]

From an external point of view nothing has really changed. We're much closer to GA for the features we have, but that feature set does not include geo queries. I can't comment on when geo queries are coming but they are definitely on our list of things to do.