Convert StorageMetadata to Swift #9979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
approved these changes
Jul 19, 2022
|
I'll merge to storage-swift-phase2 now and can address any additional feedback there. |
paulb777
added a commit
that referenced
this pull request
Jul 19, 2022
paulb777
added a commit
that referenced
this pull request
Jul 25, 2022
paulb777
added a commit
that referenced
this pull request
Aug 6, 2022
paulb777
added a commit
that referenced
this pull request
Aug 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert StorageMetadata to Swift
Two long-term issues discovered:
storageReferenceproperty was never initialized and always returned nil. I removed the property and will add a release note since I'm not sure there would be value in the API even if it were implementedisFolderis never set to true. I kept this in case there is ever a request to fix/implement.