Skip to content

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jun 4, 2022

Migrates the Storage task related implementations and unit tests to Swift.

Since is most of the rest of the library, will merge to a branch until Storage is completely migrated to Swift.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 requested a review from andrewheard June 23, 2022 15:18
@paulb777 paulb777 marked this pull request as ready for review June 23, 2022 15:18
@paulb777 paulb777 requested a review from andrewheard June 28, 2022 22:52
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- only optional style nits and questions. Sorry for the delay!

Copy link
Member Author

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough review and great suggestions!

@paulb777 paulb777 merged commit 04cc06c into storage-swift-phase2 Jun 29, 2022
@paulb777 paulb777 deleted the pb-task-in-swift branch June 29, 2022 17:29
@firebase firebase locked and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants