feature: use app name instance in firebase messaging #9868
Conversation
…ion. This ports firebase/firebase-ios-sdk#9868 to the firebase-cpp-sdk repository by patching the firebase-ios-sdk when it is cloned. Once the dependency on the firebase-ios-sdk is updated to a version that already includes firebase/firebase-ios-sdk#9868 then this commit should be reverted.
* Update iOS dependencies - Tue May 31 2022 ### iOS - Firebase/Analytics → 9.1.0 - Firebase/Auth → 9.1.0 - Firebase/Core → 9.1.0 - Firebase/Crashlytics → 9.1.0 - Firebase/Database → 9.1.0 - Firebase/DynamicLinks → 9.1.0 - Firebase/Firestore → 9.1.0 - Firebase/Functions → 9.1.0 - Firebase/Installations → 9.1.0 - Firebase/Messaging → 9.1.0 - Firebase/RemoteConfig → 9.1.0 - Firebase/Storage → 9.1.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/2416912624). * CMakeLists.txt: set(RE2_BUILD_TESTING OFF CACHE BOOL "") This fixes the following build error: ``` The following tests FAILED: 1 - charclass_test (Not Run) 2 - compile_test (Not Run) 3 - filtered_re2_test (Not Run) 4 - mimics_pcre_test (Not Run) ... ``` e.g. https://github.com/firebase/firebase-cpp-sdk/runs/6676610733 This is caused by the addition of re2 to the firebase-ios-sdk in firebase/firebase-ios-sdk#9488. I'm not sure _why_ these tests can't be found; but they're superfluous anyways. So just disable them. * value_util.cc: Fix MaxValue() to no longer use designated initialization. This ports firebase/firebase-ios-sdk#9868 to the firebase-cpp-sdk repository by patching the firebase-ios-sdk when it is cloned. Once the dependency on the firebase-ios-sdk is updated to a version that already includes firebase/firebase-ios-sdk#9868 then this commit should be reverted. Co-authored-by: firebase-workflow-trigger-bot <[email protected]> Co-authored-by: Denver Coneybeare <[email protected]>
|
Thanks for the PR and sorry about the slow response. We're not likely to move too quickly on this one since there are back-end implications of multiple-app support that we're not ready to address. |
Hi, is there any progress on this issue ? May I help with something? |
|
In the meantime you can upvote the feature request #8968 to help the team prioritize. |
|
Thanks @aspicas for the contribution. I'm sorry that we aren't able to merge this right now, but we'll keep tracking it in #8968 and revisit this PR if we move forward to ensure you get credit for it. I'll close it for now since we don't have active plans to merge it. Thanks again and feel free to follow up with any further conversation on this PR or the feature request! |
Discussion
Testing
API Changes