Skip to content

Preinstall FirebaseCore for release testing. #9833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 26, 2022
Merged

Preinstall FirebaseCore for release testing. #9833

merged 23 commits into from
May 26, 2022

Conversation

granluo
Copy link
Contributor

@granluo granluo commented May 23, 2022 •
edited
Loading

  • Preinstall FirebaseCore before pushing other SDKs
  • Pass --allow-warnings to the testing from Manifest through the matrix.
  • Add retry to push specs to testing spec repo. The pod repo push wrapper will rerun once failed, e.g. race condition of pushing spec to the repo.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@granluo granluo requested a review from paulb777 May 24, 2022 00:17
@granluo granluo marked this pull request as ready for review May 25, 2022 23:21
@granluo granluo linked an issue May 26, 2022 that may be closed by this pull request
Nightly Testing Report #9837
Closed
@granluo granluo enabled auto-merge (squash) May 26, 2022 19:04
paulb777
paulb777 approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@granluo granluo merged commit 55a8146 into master May 26, 2022
@granluo granluo deleted the gl/preinstall-core branch May 26, 2022 19:32
@firebase firebase locked and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
release-tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly Testing Report
3 participants
@granluo @google-oss-bot @paulb777