python_setup.cmake: add FIREBASE_PYTHON_PYVENV_DEST_DIR cmake cache var #9669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out this workaround isn't needed. The Windows problem was using a Python interpreter without a good venv. |
dconeybe
deleted the
dconeybe/PythonSetup_FIREBASE_PYTHON_PYVENV_DEST_DIR
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the cmake cache variable
FIREBASE_PYTHON_PYVENV_DEST_DIR. This variable will be used by theFirebaseSetupPythonInterpreter()function added in #9662 to allow a custom directory to be specified for the root directory of the python virtualenvs it creates.This can be used as a workaround for virtualenv paths that exceed the Windows maximum path length of 260. For example, this happened in the
build-desktop-windows-latest-opensslworkflow in the firebase-cpp-sdk repository.#no-changelog