Add FIRESTORE_INCLUDE_OBJC cmake cache variable #9658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void building the Firestore Objective-C layer.
dconeybe
force-pushed
the
dconeybe/FirestoreInlucdeObjcCmakeCacheVar
branch
from
3c718c3 to
6a05ffd
Compare
Coverage Report 1Affected Products
Test Logs |
schmidt-sebastian
approved these changes
Apr 15, 2022
dconeybe
added a commit
to firebase/firebase-cpp-sdk
that referenced
this pull request
Apr 15, 2022
…g Objective-C parts of the iOS SDK. This won't have any effects until the iOS dependencies are updated to a version that includes firebase/firebase-ios-sdk#9658. This will fix the following build error: ``` FIRFirestore.h:147:20: error: unknown attribute 'swift_async' ignored [-Werror,-Wunknown-attributes] __attribute__((swift_async(none))); // Disable async import due to #9426. ^ 1 error generated. ``` which was introduced by firebase/firebase-ios-sdk#9502. It avoids it by simply not building the file at all :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this new
FIRESTORE_INCLUDE_OBJCcmake cache variable is set to a false value (e.g. "NO", "OFF") then theSourceandExamplesubdirectories of Firestore will not be compiled. The default value is true.This new cmake cache variable will be used by the firebase-cpp-sdk repository to avoid unnecessarily compiling the objective-c sources that it does not use. The immediate motivation is to work around the following compilation error in firebase-cpp-sdk:
e.g. https://github.com/firebase/firebase-cpp-sdk/runs/6033445422
This problematic usage of
swift_asyncwas added in #9502. Instead of trying to fix the build error when compiled by the firebase-cpp-sdk, it's easier to just disable compiling this code all together.#no-changelog