-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[v9] End beta period and update release tooling for select products #9603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report 1Affected Products
Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on CI run as good as master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please label breaking changes in the release notes (and, if applicable, actions users should take to resolve breakages).
Good point, we should document the necessary changes to the Podfile's and how to update an existing SPM project using one of the beta targets. |
Thanks @paulb777 for mentioning SPM. So, for CocoaPods users, moving products out of beta will not affect them, correct? |
It does affect existing CocoaPods users because they need to remove the explicit beta specification from their Podfile. See https://stackoverflow.com/a/64671117/556617 just like we'll need to do in our quickstarts. Yes, SPM users will be specifying a no longer existing product. |
I've updated the CHANGELOGs to reflect that moving out of beta is a breaking change (see above discussion). There were two |
cc: @weixifan |
Fixes #9367