Skip to content

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 7, 2022

Fixes #9367

@ncooke3 ncooke3 changed the title [v9] Prepare release tooling and product tags for v9 release [v9] End beta period and update release tooling for select products Apr 7, 2022
@google-oss-bot
Copy link

google-oss-bot commented Apr 7, 2022

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    FilenameBase (415e9ea)Merge (69da4ce)Diff
    local_serializer.cc89.42%88.58%-0.84%
    ordered_code.cc93.41%94.15%+0.73%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gwkpyU1Vq8.html

@ncooke3 ncooke3 requested a review from morganchen12 April 7, 2022 21:24
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on CI run as good as master

Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please label breaking changes in the release notes (and, if applicable, actions users should take to resolve breakages).

@paulb777
Copy link
Member

paulb777 commented Apr 7, 2022

Good point, we should document the necessary changes to the Podfile's and how to update an existing SPM project using one of the beta targets.

@ncooke3
Copy link
Member Author

ncooke3 commented Apr 7, 2022

Good point, we should document the necessary changes to the Podfile's and how to update an existing SPM project using one of the beta targets.

Thanks @paulb777 for mentioning SPM. So, for CocoaPods users, moving products out of beta will not affect them, correct?
But for SPM users, it will if the name of the library changed? Because they will try to update a product that no longer exists?

@paulb777
Copy link
Member

paulb777 commented Apr 7, 2022

It does affect existing CocoaPods users because they need to remove the explicit beta specification from their Podfile. See https://stackoverflow.com/a/64671117/556617 just like we'll need to do in our quickstarts.

Yes, SPM users will be specifying a no longer existing product.

@ncooke3
Copy link
Member Author

ncooke3 commented Apr 8, 2022

I've updated the CHANGELOGs to reflect that moving out of beta is a breaking change (see above discussion).

There were two zip / quickstart failures that I believe are being addressed by #9607.

@ncooke3 ncooke3 merged commit 9e475a5 into master Apr 8, 2022
@ncooke3 ncooke3 deleted the nc/exit-beta branch April 8, 2022 16:00
@ncooke3
Copy link
Member Author

ncooke3 commented Apr 8, 2022

cc: @weixifan

@firebase firebase locked and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End Beta period for Swift libraries
5 participants