Swift first exception messages #8295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Member
Author
|
Hmm would this type of public-facing change require CHANGELOG updates? |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
|
paulb777
approved these changes
Jun 23, 2021
ryanwilson
reviewed
Jun 24, 2021
FirebaseCore/Sources/FIRApp.m
Outdated
Comment on lines
131
to
136
| [NSException | ||
| raise:kFirebaseCoreErrorDomain | ||
| format:@"`FirebaseApp.configure()` (`[FIRApp configure];` in Objective-C) could not find " | ||
| @"a valid GoogleService-Info.plist in your project. Please download one " | ||
| @"from %@.", | ||
| kPlistURL]; |
Member
There was a problem hiding this comment.
@granluo here's something we should discuss: excluding code coverage for cross product changes. ex RTDB was changed in this PR so incremental code coverage is running, but this change is in FirebaseCore and we wouldn't expect full code coverage on FirebaseCore from the RTDB tests.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing exception messages to be more Swift oriented.
Follow-up PR to conversation from #8266 (comment)