Skip to content

Revert changes in Crashlytics version - as it's causing an issue with the version associated with the crash upload #6955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2020
Merged

Revert changes in Crashlytics version - as it's causing an issue with the version associated with the crash upload #6955

merged 2 commits into from
Nov 11, 2020

Conversation

tejasd
Copy link
Contributor

@tejasd tejasd commented Nov 11, 2020 •
edited
Loading

#no-changelog

b/172929809

@google-cla google-cla bot added the cla: yes label Nov 11, 2020
@tejasd tejasd requested review from paulb777 and samedson November 11, 2020 16:15
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

paulb777
paulb777 approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this impact 3P? Do we need a patch for 7.1.0?

@tejasd
Copy link
Contributor Author

tejasd commented Nov 11, 2020

It is very likely affecting 3P as well - but I haven't tested it. If you don't mind, I'll merge it in right now and copybara it (so that it unblocks the 1P customer) - and I will confirm the 3P situation so that we can release patch.

@tejasd tejasd merged commit 1adc4a1 into master Nov 11, 2020
@samedson
Copy link
Contributor

@paulb777 so far I'm not seeing this affect 3Ps

tejasd added a commit that referenced this pull request Nov 11, 2020
@tejasd
Revert "Revert changes in Crashlytics version - as it's causing an is…
f426e6e 
…sue with the version associated with the crash upload (#6955)"

This reverts commit 1adc4a1.
@tejasd
Copy link
Contributor Author

tejasd commented Nov 11, 2020

@paulb777 A patch shouldn't be needed - there's a backend change that'll fix it + revert of this revert + fixes - #6958

tejasd added a commit that referenced this pull request Nov 11, 2020
@tejasd
Bring back the changes of reading the version from FIRCore with fixes…
6de9131 
… + unit test. (#6958)

* Revert "Revert changes in Crashlytics version - as it's causing an issue with the version associated with the crash upload (#6955)"

This reverts commit 1adc4a1.

* Fix the issue that was causing the problem

* Add unit test to make sure this is caught in case of changes.
@firebase firebase locked and limited conversation to collaborators Dec 12, 2020
@paulb777 paulb777 deleted the td/revert-crashlytics-version-2 branch January 28, 2021 04:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@samedson samedson Awaiting requested review from samedson

Assignees
No one assigned
Labels
api: crashlytics cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tejasd @google-oss-bot @samedson @paulb777