Skip to content

7.0.0 cherry-pick: Fixed broken callback to AppDelegate (#6800) #6801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2020
Merged

7.0.0 cherry-pick: Fixed broken callback to AppDelegate (#6800) #6801

merged 1 commit into from
Oct 21, 2020

Conversation

paulb777
Copy link
Member

#no-changelog

@eldhosembabu @paulb777
Fixed broken callback to AppDelegate (#6800)
5cc4150 
Fixed broken callback to AppDelegate after retrieving a dynamic link during fresh app start.
The AppDelegate call was broken in PR : #6517

Reverting to the old implementation of dynamic link passing to App delegate with changes to remove iOS 9 checks.
Using new "openURL" method instead of the deprecated one.
Clean up in the sample app pod file.
@paulb777 paulb777 requested a review from eldhosembabu October 21, 2020 21:58
@google-cla google-cla bot added the cla: yes label Oct 21, 2020
@paulb777 paulb777 merged commit 4368b98 into release-7.0 Oct 21, 2020
@paulb777 paulb777 deleted the pb-cp6800 branch October 21, 2020 22:06
@firebase firebase locked and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eldhosembabu eldhosembabu Awaiting requested review from eldhosembabu

1 more reviewer

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: dynamiclinks cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulb777 @maksymmalyhin @google-oss-bot @eldhosembabu