Skip to content

Make all GoogleUtilities APIs public #6588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 29, 2020
Merged

Make all GoogleUtilities APIs public #6588

merged 10 commits into from
Sep 29, 2020

Conversation

paulb777
Copy link
Member

  • Makes all GoogleUtilities API usage consistent
  • Eliminates need for ifdef differences between SwiftPM and CocoaPods
  • Enables transition of GoogleUtilities to another repo without a breaking change

@paulb777 paulb777 marked this pull request as draft September 28, 2020 21:36
@paulb777 paulb777 marked this pull request as ready for review September 29, 2020 04:12
@paulb777 paulb777 requested a review from ryanwilson September 29, 2020 13:33
ryanwilson
ryanwilson approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the small spelling nit, just want to check to validate we're okay with locking in the API and having to make larger coordinated breaks now.

GoogleUtilities/CHANGELOG.md Outdated
@@ -1,3 +1,6 @@
# 7.0.0
- All APIs are now public. All CocoaPods private headers are tranitioned to public.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transitioned

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to leave a comment mentioning that it's still not for non-Google usage?

@paulb777 paulb777 merged commit f2bcd5d into firebase7-main Sep 29, 2020
@paulb777 paulb777 deleted the pb-gu-public branch September 29, 2020 14:26
@firebase firebase locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
api: appdistribution api: auth api: core api: dynamiclinks api: inappmessaging Firebase In App Messaging api: installations api: instanceid api: messaging api: remoteconfig cla: yes GoogleUtilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulb777 @ryanwilson @googlebot @google-oss-bot