Port FIRDocumentChange to C++. #2687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create C++ api::DocumentChange class. * Make FIRDocumentChange a wrapper over DocumentChange. * Moved documentChangesForSnapshot helper from FIRDocumentChange to where it's used in QuerySnapshot. I think this is cleaner.
var-const
suggested changes
Apr 1, 2019
mikelehen
force-pushed
the
mikelehen/port-documentchange
branch
from
c930f46 to
8480ce3
Compare
mikelehen
force-pushed
the
mikelehen/port-documentchange
branch
from
8480ce3 to
5afd44e
Compare
mikelehen
commented
Apr 2, 2019
Contributor
Author
mikelehen
left a comment
mikelehen
left a comment
There was a problem hiding this comment.
Thanks for the thorough review! Fixed (almost) everything, but left a couple questions.
var-const
approved these changes
Apr 2, 2019
Corrob
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Create C++ api::DocumentChange class. * Make FIRDocumentChange a wrapper over api::DocumentChange. * Moved documentChangesForSnapshot helper from FIRDocumentChange to where it's used in QuerySnapshot. I think this is cleaner.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where it's used in QuerySnapshot. I think this is cleaner.