GULLogger - count errors and warnigns #2601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maksymmalyhin
commented
Mar 21, 2019
maksymmalyhin
commented
- logic to count error and warning messages added to GULLogger (Remove logging count for this release. #1201 used as a base)
paulb777
reviewed
Mar 21, 2019
Member
paulb777
left a comment
paulb777
left a comment
There was a problem hiding this comment.
LGTM, what is the plan for a client?
Contributor
Author
paulb777
approved these changes
Mar 21, 2019
maksymmalyhin
added a commit
that referenced
this pull request
Apr 3, 2019
This reverts commit 1e08a55.
Corrob
pushed a commit
that referenced
this pull request
Apr 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.