Skip to content

Make Firebase Performance XCode 15 compatible. #11439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 14, 2023
Merged

Make Firebase Performance XCode 15 compatible. #11439

merged 6 commits into from
Jun 14, 2023

Conversation

@visumickey
Copy link
Contributor

@visumickey visumickey commented Jun 14, 2023 •
edited
Loading

Fixes #11397. Includes 2 changes:

  1. Fix the failing unit test for XCode15
  2. Remote the CTCarrier dependency since it is deprecated

@google-oss-bot
Copy link

google-oss-bot commented Jun 14, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebasePerformance-iOS-FirebasePerformance.framework

    Overall coverage changed from 94.90% (0323c2d) to 94.69% (bd5e2bc) by -0.21%.

    FilenameBase (0323c2d)Merge (bd5e2bc)Diff
    FPRDataUtils.m96.52%96.04%-0.48%
    FPRNanoPbUtils.m88.99%86.53%-2.45%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/RkUbinUw5t.html

@visumickey visumickey changed the title Perf xcode15 Make Firebase Performance XCode 15 compatible. Jun 14, 2023
paulb777
paulb777 approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm still seeing a crash running the unit tests and will try to isolate after.

@visumickey visumickey merged commit ef571e0 into master Jun 14, 2023
@visumickey visumickey deleted the perf_xcode15 branch June 14, 2023 21:39
@firebase firebase locked and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@themiswang themiswang themiswang approved these changes

@samedson samedson Awaiting requested review from samedson

Assignees

No one assigned

Labels

api: performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Address Firebase Performance issues with Xcode 15

4 participants

@visumickey @google-oss-bot @paulb777 @themiswang