Skip to content

Xcode 14.3 test_specs always need requires_app_host #11198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2023
Merged

Xcode 14.3 test_specs always need requires_app_host #11198

merged 1 commit into from
Apr 27, 2023

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Apr 27, 2023

Get pod lib lint unit tests working on Xcode 14.3

@google-oss-bot
Copy link

google-oss-bot commented Apr 27, 2023

Coverage Report 1

Affected Products

  • FirebaseStorage-iOS-FirebaseStorage.framework

    Overall coverage changed from ? (6bf654b) to 0.00% (6a4c3d6) by ?.

    21 individual files with coverage change

    FilenameBase (6bf654b)Merge (6a4c3d6)Diff
    AsyncAwait.swift?0.00%?
    Result.swift?0.00%?
    Storage.swift?0.00%?
    StorageComponent.swift?0.00%?
    StorageDeleteTask.swift?0.00%?
    StorageDownloadTask.swift?0.00%?
    StorageError.swift?0.00%?
    StorageGetDownloadURLTask.swift?0.00%?
    StorageGetMetadataTask.swift?0.00%?
    StorageListResult.swift?0.00%?
    StorageListTask.swift?0.00%?
    StorageMetadata.swift?0.00%?
    StorageObservableTask.swift?0.00%?
    StoragePath.swift?0.00%?
    StorageReference.swift?0.00%?
    StorageTask.swift?0.00%?
    StorageTaskSnapshot.swift?0.00%?
    StorageTokenAuthorizer.swift?0.00%?
    StorageUpdateMetadataTask.swift?0.00%?
    StorageUploadTask.swift?0.00%?
    StorageUtils.swift?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/obr0DeJrr3.html

ncooke3
ncooke3 approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How'd this requirement surface?

@paulb777
Copy link
Member Author

paulb777 commented Apr 27, 2023

I found it debugging why pod lib lint wasn't working with Xcode 14.3

@paulb777 paulb777 merged commit a72a3b6 into master Apr 27, 2023
@paulb777 paulb777 deleted the pb-xc143-testspecs branch April 27, 2023 15:12
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees

No one assigned

Labels

api: appdistribution api: core api: crashlytics api: functions api: storage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulb777 @google-oss-bot @ncooke3