Firestore Spec Tests: Port JS PR 7257 (use strings for targetPurpose)
#11191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 26, 2023
dconeybe
changed the base branch from
master
to
dconeybe/SpecTestPortJsSdkPr7229
cherylEnkidu
approved these changes
Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port spec test changes from firebase/firebase-js-sdk#7257 (Firestore: use string values for TargetPurpose enum).
For reference, here is the Android port of the same change: firebase/firebase-android-sdk#4931
#no-changelog