Skip to content

Add new goog-listen-tags for BloomFilter #10977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Mar 25, 2023
Merged

Add new goog-listen-tags for BloomFilter #10977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
969f2ed
add unchanged names to existence filter and modify spec test runner
milaGGL Feb 24, 2023
b66b02b
Merge branch 'mila/BloomFilter' into mila/BloomFilter-add--existence-…
milaGGL Feb 28, 2023
1df9410
use BloomFilter instead of proto
milaGGL Feb 28, 2023
1e67033
update serializer
milaGGL Feb 28, 2023
899e3cc
add bloomfilter equality test
milaGGL Mar 3, 2023
3faa3e8
Merge branch 'mila/BloomFilter' into mila/BloomFilter-add--existence-…
milaGGL Mar 6, 2023
468f967
make unchanged_names optional in proto
milaGGL Mar 7, 2023
23f0fb1
handle invalid unchanged-names input with BloomFilter::Create
milaGGL Mar 7, 2023
475fffb
format the comments
milaGGL Mar 7, 2023
5bda231
Merge branch 'mila/BloomFilter' into mila/BloomFilter-add--existence-…
milaGGL Mar 13, 2023
11158e5
port spec tests
milaGGL Mar 13, 2023
05caaeb
change unchanged_names to Bloom_filter
milaGGL Mar 13, 2023
b0bb8bf
add GetDatabaseId to the targetMetadataProvider
milaGGL Mar 14, 2023
d56f4df
remove the parsing unchanged_names to BloomFilter logic
milaGGL Mar 14, 2023
4158352
sort the actual and expected events in spec test before comparing them
milaGGL Mar 14, 2023
2b8533c
Merge branch 'mila/BloomFilter-add--existence-filter-class' into mila…
milaGGL Mar 14, 2023
ae930ef
Revert "Merge branch 'mila/BloomFilter-add--existence-filter-class' i…
milaGGL Mar 15, 2023
91a42e6
resolve comments
milaGGL Mar 16, 2023
e694551
Merge branch 'mila/BloomFilter' into mila/BloomFilter-add--existence-…
milaGGL Mar 16, 2023
db883fb
Merge branch 'mila/BloomFilter-add--existence-filter-class' into mila…
milaGGL Mar 16, 2023
a2b7408
format
milaGGL Mar 16, 2023
f6b062f
log error message
milaGGL Mar 17, 2023
0de7946
Merge branch 'mila/BloomFilter' into mila/BloomFilter-apply-bloom-fil…
milaGGL Mar 17, 2023
01c332b
merge queryPurpose spec test check
milaGGL Mar 17, 2023
4e1e489
add back the expectedCount check get deleted
milaGGL Mar 17, 2023
523fd6c
re-write CompareBits()
dconeybe Mar 17, 2023
6bbc6b2
fix typo
dconeybe Mar 17, 2023
2a71c20
resolve comments
milaGGL Mar 17, 2023
4a97630
resolve comments
milaGGL Mar 17, 2023
3eec288
Update bloom_filter.cc
milaGGL Mar 17, 2023
f28689c
Merge branch 'mila/BloomFilter-add--existence-filter-class' into mila…
milaGGL Mar 17, 2023
ffeac29
add test coverage for ExistenceFilter with not null BloomFilter
milaGGL Mar 17, 2023
1389257
Merge branch 'mila/BloomFilter' into mila/BloomFilter-apply-bloom-fil…
milaGGL Mar 20, 2023
dd0d0fd
nit
milaGGL Mar 20, 2023
f412d20
format
milaGGL Mar 20, 2023
2f93851
initial code
milaGGL Mar 21, 2023
6fe1859
Merge branch 'mila/BloomFilter' into mila/BloomFilter-add-new-goog-li…
milaGGL Mar 24, 2023
9079c28
format
milaGGL Mar 24, 2023
0e7af0b
change ApplyBloomFilter comment
milaGGL Mar 24, 2023
78d3fbb
resolve comments
milaGGL Mar 24, 2023
5eda3ae
resolve comment
milaGGL Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Firestore/Example/Tests/SpecTests/json/bundle_spec_test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,7 +1166,7 @@
}
],
"resumeToken": "",
"targetPurpose": 2
"targetPurpose": 3
},
"2": {
"queries": [
Expand Down
Loading