Skip to content

[Infra] Upgrade to clang-format16 #10973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2023
Merged

[Infra] Upgrade to clang-format16 #10973

merged 1 commit into from
Mar 20, 2023

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Mar 20, 2023 •
edited
Loading

Context

  • clang-format15 was removed from GHA. This PR specifies clang-format16 as the repo's corresponding clang-format version.

cc: @wu-hui

#no-changelog

@ncooke3 ncooke3 requested review from andrewheard and paulb777 March 20, 2023 16:31
paulb777
paulb777 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ncooke3 ncooke3 merged commit 867697b into master Mar 20, 2023
@ncooke3 ncooke3 deleted the nc/clang-format16 branch March 20, 2023 16:47
@google-oss-bot
Copy link

google-oss-bot commented Mar 20, 2023

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.24% (5bb05e0) to 88.22% (8d8b2c5) by -0.02%.

    FilenameBase (5bb05e0)Merge (8d8b2c5)Diff
    exception.cc84.21%23.68%-60.53%
    exception_apple.mm65.52%96.55%+31.03%
    leveldb_key.cc98.14%98.82%+0.69%
    task.cc93.91%94.78%+0.87%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EewMD1lgAu.html

paulb777 pushed a commit that referenced this pull request Mar 22, 2023
@ncooke3 @paulb777
[Infra] Upgrade to clang-format16 (#10973)
c68e314
paulb777 added a commit that referenced this pull request Mar 22, 2023
@paulb777 @ncooke3
[Infra] Upgrade to clang-format16 (#10973) (#10989)
acfe0c6 
Co-authored-by: Nick Cooke <[email protected]>
@firebase firebase locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@andrewheard andrewheard Awaiting requested review from andrewheard

Assignees

No one assigned

Labels

api: crashlytics api: database api: firestore api: installations api: remoteconfig

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ncooke3 @google-oss-bot @paulb777