Skip to content

Update Remote Config real-time config update ref-docs #10962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 20, 2023
Merged

Update Remote Config real-time config update ref-docs #10962

merged 6 commits into from
Mar 20, 2023

Conversation

@qdpham13
Copy link
Contributor

@qdpham13 qdpham13 commented Mar 16, 2023 •
edited by morganchen12
Loading

Update Remote Config real-time reference docs to be more description and uniform. #no-changelog

@google-oss-bot
Copy link

google-oss-bot commented Mar 16, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    Overall coverage changed from ? (867697b) to 70.94% (b170b2a) by ?.

    13 individual files with coverage change

    FilenameBase (867697b)Merge (b170b2a)Diff
    FIRConfigValue.m?58.70%?
    FIRRemoteConfig.m?83.91%?
    FIRRemoteConfigComponent.m?97.06%?
    FIRRemoteConfigUpdate.m?100.00%?
    RCNConfigContent.m?81.90%?
    RCNConfigDBManager.m?76.34%?
    RCNConfigExperiment.m?90.70%?
    RCNConfigFetch.m?71.09%?
    RCNConfigRealtime.m?35.85%?
    RCNConfigSettings.m?62.81%?
    RCNDevice.m?81.29%?
    RCNPersonalization.m?89.74%?
    RCNUserDefaultsManager.m?98.43%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CSC6AgBB6o.html

morganchen12
morganchen12 reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait for Dana's approval.

danasilver
danasilver approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@danasilver danasilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple suggestions

@qdpham13 qdpham13 requested a review from danasilver March 17, 2023 17:00
@danasilver
Copy link
Contributor

danasilver commented Mar 17, 2023

LGTM pending the backtick linking discussion

@google-oss-bot
Copy link

google-oss-bot commented Mar 20, 2023

Size Report 1

Affected Products

  • FirebaseRemoteConfig

    TypeBase (867697b)Merge (b170b2a)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fU0HyH2KWU.html

@qdpham13 qdpham13 merged commit 7a95f0b into master Mar 20, 2023
@qdpham13 qdpham13 deleted the rc-ref-docs branch March 20, 2023 17:58
@firebase firebase locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@morganchen12 morganchen12 morganchen12 left review comments

+1 more reviewer

@danasilver danasilver danasilver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: remoteconfig public-api-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qdpham13 @google-oss-bot @danasilver @morganchen12