-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Export *just* the AppDistributionInternal source code to master to fix CI issues #10937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I believe two other alternatives to this would be pushing AppDistribution-internal to SpecsDev or temporarily disabling the failing CI job in your branch. |
|
Pushing it to SpecsDev errors out - which occurs because it's not possible to specify a branch besides It's possible to temporarily disable the CI tasks - but this seems like a harmless change (it won't be included in The only thing I'm not sure if anything is needed, is to prevent it from being pushed to |
paulb777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. You'd need to change the podspec to successfully push to SpecsDev.
I agree it should be safe to do it this other way. We won't try to publish until it gets added to FirebaseManifest.swift
There are CI failures which seem to need this source code in master.
Eg. https://github.com/firebase/firebase-ios-sdk/actions/runs/4387975314/jobs/7683918159
This PR is an attempt at that.
#no-changelog