Skip to content

Conversation

@tejasd
Copy link
Contributor

@tejasd tejasd commented Mar 10, 2023

There are CI failures which seem to need this source code in master.

Eg. https://github.com/firebase/firebase-ios-sdk/actions/runs/4387975314/jobs/7683918159

This PR is an attempt at that.

#no-changelog

@tejasd tejasd requested review from paulb777 and tagboola and removed request for tagboola March 10, 2023 20:56
@tejasd tejasd requested a review from tagboola March 10, 2023 22:36
@paulb777
Copy link
Member

I believe two other alternatives to this would be pushing AppDistribution-internal to SpecsDev or temporarily disabling the failing CI job in your branch.

@tejasd
Copy link
Contributor Author

tejasd commented Mar 13, 2023

Pushing it to SpecsDev errors out - which occurs because it's not possible to specify a branch besides master in the podspec AFAICT.

Validating spec
 -> FirebaseAppDistributionInternal (10.5.0-beta)
    - ERROR | [iOS] file patterns: The `source_files` pattern did not match any file.
    - ERROR | [iOS] file patterns: The `resource_bundles` pattern for `AppDistributionInternalResources` did not match any file.
    - ERROR | [iOS] unknown: Encountered an unknown error (Unable to install the `FirebaseAppDistributionInternal` pod, because the `FirebaseAppDistributionInternal-Unit-unit` target in Xcode would have no sources to compile.) during validation.

It's possible to temporarily disable the CI tasks - but this seems like a harmless change (it won't be included in spm, it's not added as a dependency to FirebaseAppDistribution.

The only thing I'm not sure if anything is needed, is to prevent it from being pushed to https://cdn.cocoapods.org/ from master?

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. You'd need to change the podspec to successfully push to SpecsDev.

I agree it should be safe to do it this other way. We won't try to publish until it gets added to FirebaseManifest.swift

@tejasd tejasd changed the title Export *just* the AppDistributionInternal cocoapod to master to fix CI issues Export *just* the AppDistributionInternal source code to master to fix CI issues Mar 13, 2023
@tejasd tejasd merged commit 7a1a71c into master Mar 13, 2023
@tejasd tejasd deleted the fad/appdistributioninternal branch March 13, 2023 17:50
@firebase firebase locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants