Skip to content

[FirebaseCore] Use optional instead of error #10906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2023
Merged

[FirebaseCore] Use optional instead of error #10906

merged 3 commits into from
Mar 7, 2023

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Mar 7, 2023

#no-changelog

paulb777
paulb777 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ncooke3 ncooke3 merged commit 1f3befa into master Mar 7, 2023
@ncooke3 ncooke3 deleted the nc/fix-hb-errors branch March 7, 2023 18:43
@google-oss-bot
Copy link

google-oss-bot commented Mar 7, 2023

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.29% (c0e6ac1) to 88.27% (24a8936) by -0.02%.

    FilenameBase (c0e6ac1)Merge (24a8936)Diff
    leveldb_key.cc98.63%98.14%-0.49%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/smdDamwKnv.html

@paulb777 paulb777 mentioned this pull request Mar 7, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees

No one assigned

Labels

api: core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ncooke3 @google-oss-bot @paulb777