Skip to content

Lru Memory GC #10905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Apr 18, 2023
Merged

Lru Memory GC #10905

merged 42 commits into from
Apr 18, 2023

Conversation

@wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Mar 7, 2023 •
edited
Loading

see: firebase/firebase-js-sdk#6943 and go/firestore-memory-lru

@google-oss-bot
Copy link

google-oss-bot commented Mar 7, 2023

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (1f3befa)Merge (af43d90)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yCAUTrw8Vt.html

@google-oss-bot
Copy link

google-oss-bot commented Mar 7, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.13% (6504a2b) to 87.98% (86cd6ff) by -0.15%.

    FilenameBase (6504a2b)Merge (86cd6ff)Diff
    firestore_client.cc98.88%98.91%+0.03%
    FIRLocalCacheSettings.mm44.62%46.04%+1.43%
    leveldb_lru_reference_delegate.cc94.31%95.93%+1.63%
    memory_mutation_queue.cc98.78%100.00%+1.22%
    ordered_code.cc94.39%93.90%-0.49%
    proto_sizer.cc72.73%100.00%+27.27%
    settings.cc89.51%83.11%-6.40%
    task.cc94.78%93.91%-0.87%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/APRZi3ofQK.html

@wu-hui wu-hui requested a review from ehsannas April 14, 2023 14:19
ehsannas
ehsannas approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a few nits.

wu-hui
wu-hui commented Apr 18, 2023
View reviewed changes
Copy link
Contributor Author

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

wu-hui added 2 commits April 18, 2023 10:27
@wu-hui
Revert "feedback"
eb9269e 
This reverts commit 12a70a0.
@wu-hui
Revert "Revert "feedback""
6d10711 
This reverts commit eb9269e.
@wu-hui wu-hui closed this Apr 18, 2023
@wu-hui wu-hui reopened this Apr 18, 2023
@wu-hui wu-hui closed this Apr 18, 2023
@wu-hui wu-hui reopened this Apr 18, 2023
@wu-hui wu-hui merged commit 15a38d3 into master Apr 18, 2023
@wu-hui wu-hui deleted the wuandy/LruGC branch April 18, 2023 17:00
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@ehsannas ehsannas

Labels

api: firestore public-api-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wu-hui @google-oss-bot @ehsannas