Skip to content

Upgrade nanopb to 0.3.9.9 for collection of SDKs #10447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2022
Merged

Upgrade nanopb to 0.3.9.9 for collection of SDKs #10447

merged 1 commit into from
Nov 2, 2022

Conversation

@samedson
Copy link
Contributor

@samedson samedson commented Nov 2, 2022 •
edited
Loading

Follow up from #10439

#no-changelog

paulb777
paulb777 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@firebase firebase deleted a comment from google-oss-bot Nov 2, 2022
@google-oss-bot
Copy link

google-oss-bot commented Nov 2, 2022

Size Report 1

Affected Products

  • FirebaseCrashlytics

    TypeBase (ba0f4f2)Merge (6604448)Diff
    CocoaPods?-51.5 kB? (?)

  • FirebaseInAppMessaging

    TypeBase (ba0f4f2)Merge (6604448)Diff
    CocoaPods?-51.5 kB? (?)

  • FirebaseMessaging

    TypeBase (ba0f4f2)Merge (6604448)Diff
    CocoaPods?-51.5 kB? (?)

  • FirebasePerformance

    TypeBase (ba0f4f2)Merge (6604448)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GYpmqHMiE8.html

@google-oss-bot
Copy link

google-oss-bot commented Nov 2, 2022

Coverage Report 1

Affected Products

  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    Overall coverage changed from ? (ba0f4f2) to 46.15% (6604448) by ?.

    42 individual files with coverage change

    FilenameBase (ba0f4f2)Merge (6604448)Diff
    FIRIAMActionURLFollower.m?52.78%?
    FIRIAMActivityLogger.m?60.96%?
    FIRIAMAnalyticsEventLoggerImpl.m?60.71%?
    FIRIAMBannerViewController.m?0.00%?
    FIRIAMBannerViewUIWindow.m?0.00%?
    FIRIAMBaseRenderingViewController.m?0.00%?
    FIRIAMBookKeeper.m?88.41%?
    FIRIAMCardViewController.m?0.00%?
    FIRIAMClearcutHttpRequestSender.m?0.00%?
    FIRIAMClearcutLogger.m?62.50%?
    FIRIAMClearcutLogStorage.m?62.50%?
    FIRIAMClearcutUploader.m?90.34%?
    FIRIAMClientInfoFetcher.m?61.98%?
    FIRIAMDefaultDisplayImpl.m?1.78%?
    FIRIAMDisplayCheckOnAnalyticEventsFlow.m?0.00%?
    FIRIAMDisplayCheckOnAppForegroundFlow.m?0.00%?
    FIRIAMDisplayCheckOnFetchDoneNotificationFlow.m?0.00%?
    FIRIAMDisplayCheckTriggerFlow.m?0.00%?
    FIRIAMDisplayExecutor.m?65.99%?
    FIRIAMDisplayTriggerDefinition.m?68.42%?
    FIRIAMElapsedTimeTracker.m?92.31%?
    FIRIAMFetchFlow.m?80.35%?
    FIRIAMFetchOnAppForegroundFlow.m?0.00%?
    FIRIAMFetchResponseParser.m?86.11%?
    FIRIAMImageOnlyViewController.m?0.00%?
    FIRIAMMessageClientCache.m?78.11%?
    FIRIAMMessageContentDataWithImageURL.m?80.88%?
    FIRIAMMessageDefinition.m?100.00%?
    FIRIAMModalViewController.m?0.00%?
    FIRIAMMsgFetcherUsingRestful.m?71.01%?
    FIRIAMRenderingEffectSetting.m?100.00%?
    FIRIAMRenderingWindowHelper.m?0.00%?
    FIRIAMRuntimeManager.m?0.00%?
    FIRIAMSDKModeManager.m?93.22%?
    FIRIAMSDKSettings.m?0.00%?
    FIRIAMServerMsgFetchStorage.m?0.00%?
    FIRIAMTimeFetcher.m?0.00%?
    FIRInAppMessaging+Bootstrap.m?0.00%?
    FIRInAppMessaging.m?3.37%?
    FIRInAppMessagingRenderingDataClasses.m?89.29%?
    NSString+FIRInterlaceStrings.m?100.00%?
    UIColor+FIRIAMHexString.m?100.00%?

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from ? (ba0f4f2) to 63.89% (6604448) by ?.

    29 individual files with coverage change

    FilenameBase (ba0f4f2)Merge (6604448)Diff
    FIRMessaging.m?55.68%?
    FIRMessagingAnalytics.m?82.14%?
    FIRMessagingAPNSInfo.m?86.96%?
    FIRMessagingAuthKeychain.m?87.42%?
    FIRMessagingAuthService.m?92.39%?
    FIRMessagingBackupExcludedPlist.m?85.07%?
    FIRMessagingCheckinPreferences.m?98.02%?
    FIRMessagingCheckinService.m?90.54%?
    FIRMessagingCheckinStore.m?81.68%?
    FIRMessagingContextManagerService.m?66.48%?
    FIRMessagingExtensionHelper.m?78.57%?
    FIRMessagingKeychain.m?93.39%?
    FIRMessagingLogger.m?100.00%?
    FIRMessagingPendingTopicsList.m?89.80%?
    FIRMessagingPersistentSyncMessage.m?38.10%?
    FIRMessagingPubSub.m?52.14%?
    FIRMessagingRemoteNotificationsProxy.m?76.35%?
    FIRMessagingRmqManager.m?57.42%?
    FIRMessagingSyncMessageManager.m?68.89%?
    FIRMessagingTokenDeleteOperation.m?0.00%?
    FIRMessagingTokenFetchOperation.m?75.91%?
    FIRMessagingTokenInfo.m?78.86%?
    FIRMessagingTokenManager.m?37.55%?
    FIRMessagingTokenOperation.m?96.45%?
    FIRMessagingTokenStore.m?66.00%?
    FIRMessagingTopicOperation.m?0.00%?
    FIRMessagingUtilities.m?56.73%?
    NSDictionary+FIRMessaging.m?27.27%?
    NSError+FIRMessaging.m?100.00%?

  • FirebasePerformance-iOS-FirebasePerformance.framework

    Overall coverage changed from ? (ba0f4f2) to 92.26% (6604448) by ?.

    43 individual files with coverage change

    FilenameBase (ba0f4f2)Merge (6604448)Diff
    FIRHTTPMetric.m?100.00%?
    FIRPerformance.m?95.15%?
    FIRTrace.m?93.63%?
    FPRAppActivityTracker.m?93.13%?
    FPRClassInstrumentor.m?91.67%?
    FPRClient.m?57.94%?
    FPRConfiguration.m?47.37%?
    FPRConfigurations.m?93.75%?
    FPRConsoleURLGenerator.m?100.00%?
    FPRCounterList.m?100.00%?
    FPRCPUGaugeCollector.m?89.91%?
    FPRCPUGaugeData.m?100.00%?
    FPRDataUtils.m?96.52%?
    FPRDiagnostics.m?84.48%?
    FPRGaugeManager.m?98.69%?
    FPRGDTEvent.m?80.00%?
    FPRGDTLogger.m?100.00%?
    FPRGDTLogSampler.m?90.16%?
    FPRGDTRateLimiter.m?94.59%?
    FPRInstrument.m?100.00%?
    FPRInstrumentation.m?100.00%?
    FPRMemoryGaugeCollector.m?94.12%?
    FPRMemoryGaugeData.m?100.00%?
    FPRNanoPbUtils.m?87.42%?
    FPRNetworkInstrumentHelpers.m?29.17%?
    FPRNetworkTrace.m?93.47%?
    FPRNSURLConnectionDelegate.m?61.36%?
    FPRNSURLConnectionDelegateInstrument.m?98.70%?
    FPRNSURLConnectionInstrument.m?96.62%?
    FPRNSURLSessionDelegate.m?100.00%?
    FPRNSURLSessionDelegateInstrument.m?99.24%?
    FPRNSURLSessionInstrument.m?97.55%?
    FPRObjectInstrumentor.m?83.33%?
    FPRPerfDate.m?50.00%?
    FPRProxyObjectHelper.m?100.00%?
    FPRRemoteConfigFlags.m?98.09%?
    FPRScreenTraceTracker.m?97.69%?
    FPRSelectorInstrumentor.m?90.38%?
    FPRSessionDetails.m?96.43%?
    FPRSessionManager.m?87.84%?
    FPRTraceBackgroundActivityTracker.m?100.00%?
    FPRUIViewControllerInstrument.m?94.94%?
    FPRURLFilter.m?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zGUjaF8QLN.html

@samedson samedson merged commit f5af4a9 into master Nov 2, 2022
@samedson samedson deleted the nanopb-0.3.9.9 branch November 2, 2022 19:32
@firebase firebase locked and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees

No one assigned

Labels

api: crashlytics api: inappmessaging Firebase In App Messaging api: messaging api: performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samedson @google-oss-bot @paulb777