Skip to content

Firestore: Remove unused annotations.proto imports #10436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 3, 2022
Merged

Firestore: Remove unused annotations.proto imports #10436

merged 7 commits into from
Nov 3, 2022

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Nov 1, 2022

#no-changelog

@dconeybe dconeybe self-assigned this Nov 1, 2022
@google-oss-bot
Copy link

google-oss-bot commented Nov 1, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.22% (db6af01) to 88.19% (ac4b004) by -0.03%.

    FilenameBase (db6af01)Merge (ac4b004)Diff
    exception.cc84.21%23.68%-60.53%
    exception_apple.mm65.52%96.55%+31.03%
    leveldb_key.cc98.14%98.82%+0.69%
    ordered_code.cc93.90%94.39%+0.49%
    task.cc95.65%94.78%-0.87%
    write_stream.cc94.37%91.55%-2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4YUlY9f80a.html

@dconeybe dconeybe changed the base branch from master to dconeybe/NanopPbPython311Fix November 1, 2022 22:55
Base automatically changed from dconeybe/NanopPbPython311Fix to master November 2, 2022 02:55
cherylEnkidu
cherylEnkidu approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@cherylEnkidu cherylEnkidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dconeybe dconeybe merged commit c082484 into master Nov 3, 2022
@dconeybe dconeybe deleted the dconeybe/AnnotationsProtoImportWarningFix branch November 3, 2022 13:59
visumickey pushed a commit that referenced this pull request Nov 9, 2022
@dconeybe @visumickey
Firestore: Remove unused annotations.proto imports (#10436)
dd84104
@firebase firebase locked and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cherylEnkidu cherylEnkidu cherylEnkidu approved these changes

Assignees

@dconeybe dconeybe

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dconeybe @google-oss-bot @cherylEnkidu