Skip to content

Fix a bug where the linking/reauth flows errors are not caught #10407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 2, 2022
Merged

Fix a bug where the linking/reauth flows errors are not caught #10407

merged 12 commits into from
Nov 2, 2022

Conversation

@renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Oct 26, 2022

No description provided.

@google-oss-bot
Copy link

google-oss-bot commented Oct 26, 2022

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@renkelvin renkelvin changed the title Fix a bug where the linking/reauth flows error out but the error is not caught Fix a bug where the linking/reauth flows errors not caught Oct 26, 2022
@renkelvin renkelvin changed the title Fix a bug where the linking/reauth flows errors not caught Fix a bug where the linking/reauth flows errors are not caught Oct 26, 2022
@renkelvin
Copy link
Contributor Author

renkelvin commented Oct 26, 2022

Changelog: #10408

paulb777
paulb777 approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@google-oss-bot
Copy link

google-oss-bot commented Oct 28, 2022

Size Report 1

Affected Products

  • FirebaseAuth

    TypeBase (f7dea6e)Merge (61417e2)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GsvW4dbC5E.html

@renkelvin renkelvin merged commit c13cc92 into master Nov 2, 2022
@renkelvin renkelvin deleted the link-fix branch November 2, 2022 22:24
@rizafran rizafran mentioned this pull request Nov 3, 2022
Closed
@firebase firebase locked and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@rosalyntan rosalyntan rosalyntan approved these changes

@rizafran rizafran Awaiting requested review from rizafran

Assignees

No one assigned

Labels

api: auth

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@renkelvin @google-oss-bot @paulb777 @rosalyntan